Fix constructor inheritance #351
Open
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Fields can't be redefined, don't search them up the hierarchy | ||
| // Constructors can't be redefined, don't search them up the hierarchy | ||
| if ( | ||
| (access != null && (access.isPrivate() || access.isStatic() || entry instanceof FieldEntry)) |
Member
Author
There was a problem hiding this comment.
this only checks for FieldEntrys when access is non-null, as before
that doesn't seem correct, but changing it breaks tests
Member
There was a problem hiding this comment.
cc @IotaBread
reordering the check breaks shadow behaviour
i don't know exactly when the access will be null -- if we can predict which fields will have their definitions indexed, we need to document our reliance on that behaviour, and if we can't, this needs to be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #349
IndexEntryResolverto make constructors always resolve to themselvesinstanceof ClassEntrychecks that could never betruebecausegetClassChildalready excluded them