8000 FIX: Update python code to simplify and resolve FutureWarning by mmcky · Pull Request #540 · QuantEcon/lecture-python-intro · GitHub
[go: up one dir, main page]
Skip to content

FIX: Update python code to simplify and resolve FutureWarning #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 1, 2024
Merged

FIX: Update python code to simplify and resolve FutureWarning #540

merged 11 commits into from
Aug 1, 2024
+12 −39

Conversation

mmcky
Copy link
Contributor
@mmcky mmcky commented Aug 1, 2024

This PR addresses comments from @jstac in #539

Can x = np.asarray(df['income']) be simplified to x = np.array(df['income']) ?

All classes of np.assarray have been removed as they are not required.

The FutureWarnings look a bit ugly -- should we suppress them?

Addressed these using the better accessor iloc[]

@netlify Netlify
Copy link
netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit eb5c181
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66ab05b821469c000874eb73
😎 Deploy Preview https://deploy-preview-540--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky mmcky marked this pull request as ready for review August 1, 2024 03:09
@mmcky
Copy link
Contributor Author
mmcky commented Aug 1, 2024 •
edited
Loading

@jstac this addresses your comments in #539

The asarray is not required at all so I have removed them.

  • once this is green I will do a final check of the rendering to see if data or x is referenced in the text

@github-actions GitHub Actions
Copy link
github-actions bot commented Aug 1, 2024 •
edited
Loading

🚀 Deployed on https://66ab07a1e7b3586d0c99bdaa--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:16 Inactive
@mmcky
Copy link
Contributor Author
mmcky commented Aug 1, 2024 •
edited
Loading

@jstac will address the other inf issue now -- not actually getting them locally which is strange.

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:39 Inactive
@github-actions github-a 8000 ctions bot temporarily deployed to pull request August 1, 2024 03:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 03:57 Inactive
@mmcky
Copy link
Contributor Author
mmcky commented Aug 1, 2024

@jstac the latest release of anaconda fixes the issue.

I just reviewed execution and we are getting green ticks across the board so I think we are good to upgrade anaconda in this PR if you agree.

@mmcky mmcky merged commit a58c4af into main Aug 1, 2024
7 checks passed
@mmcky mmcky deleted the edit_prob2 branch August 1, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmcky @jstac
0