Remove ExceptionTypeCache #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing `ExceptionTypeCache` which was causing issues and fix for issue caused performance overhead.
jaredbroad
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionTypeCachewhich was causing issues and fix for issuecaused performance overhead.
Performance testing:
[MASTER C# IndicatorRibbonBenchmark] From PR #24
132.27 seconds at 6k data points per second. Processing total of 782,223 data points.
130.07 seconds at 6k data points per second. Processing total of 782,223 data points.
129.88 seconds at 6k data points per second. Processing total of 782,223 data points.
[This PR C# IndicatorRibbonBenchmark]
127.63 seconds at 6k data points per second. Processing total of 782,223 data points.
127.83 seconds at 6k data points per second. Processing total of 782,223 data points.
127.44 seconds at 6k data points per second. Processing total of 782,223 data points.
Results suggest the cache wasn't really giving a significant performance improvement.