8000 Support for decimal and fixing build issues in pythonnet by jaredbroad · Pull Request #1 · QuantConnect/pythonnet · GitHub
[go: up one dir, main page]

Skip to content

Support for decimal and fixing build issues in pythonnet #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def build_extension(self, ext):
enable_shared = False

if not enable_shared:
defines.append("PYTHON_WITHOUT_ENABLE_SHARED")
pass#defines.append("PYTHON_WITHOUT_ENABLE_SHARED")

if hasattr(sys, "abiflags"):
if "d" in sys.abiflags:
Expand Down
39 changes: 38 additions & 1 deletion src/runtime/converter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ internal static IntPtr GetPythonTypeByAlias(Type op)
return Runtime.PyLongType;
}
else if ((op == doubleType) ||
(op == singleType))
(op == singleType) ||
(op == decimalType))
{
return Runtime.PyFloatType;
}
Expand All @@ -126,6 +127,12 @@ internal static IntPtr ToPython<T>(T value)

internal static IntPtr ToPython(Object value, Type type)
{
if(value is PyObject)
{
IntPtr handle = ((PyObject)value).Handle;
Runtime.XIncref(handle);
return handle;
}
IntPtr result = IntPtr.Zero;

// Null always converts to None in Python.
Expand Down Expand Up @@ -208,6 +215,17 @@ internal static IntPtr ToPython(Object value, Type type)
case TypeCode.UInt64:
return Runtime.PyLong_FromUnsignedLongLong((ulong)value);

case TypeCode.Decimal:
IntPtr mod = Runtime.PyImport_ImportModule("decimal");
IntPtr ctor = Runtime.PyObject_GetAttrString(mod, "Decimal");

string d2s = ((decimal)value).ToString(nfi);
IntPtr d2p = Runtime.PyString_FromString(d2s);
IntPtr args = Runtime.PyTuple_New(1);
Runtime.PyTuple_SetItem(args, 0, d2p);

return Runtime.PyObject_CallObject(ctor, args);

default:
if (value is IEnumerable)
{
Expand Down Expand Up @@ -265,6 +283,13 @@ internal static bool ToManaged(IntPtr value, Type type,
internal static bool ToManagedValue(IntPtr value, Type obType,
out Object result, bool setError)
{
if (obType == typeof(PyObject))
{
Runtime.XIncref(value); // PyObject() assumes ownership
result = new PyObject(value);
return true;
}

// Common case: if the Python value is a wrapped managed object
// instance, just return the wrapped object.
ManagedType mt = ManagedType.GetManagedObject(value);
Expand Down Expand Up @@ -785,6 +810,18 @@ static bool ToPrimitive(IntPtr value, Type obType, out Object result,
}
8000 result = d;
return true;

case TypeCode.Decimal:
op = Runtime.PyObject_Str(value);
decimal m;
string sm = Runtime.GetManagedString(op);
if (!Decimal.TryParse(sm, NumberStyles.Number, nfi, out m))
{
goto type_error;
}
Runtime.XDecref(op);
result = m;
return true;
}


Expand Down
2 changes: 1 addition & 1 deletion src/runtime/pyobject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ protected virtual void Dispose(bool disposing)
disposed = true;
}
}

public void Dispose()
{
Dispose(true);
Expand Down
14 changes: 14 additions & 0 deletions src/testing/callbacktest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,18 @@ public string Call_simpleDefaultArg_WithEmptyArgs(string moduleName)
}
}
}

//==========================================================================
// Tests calling from Python into C# and back into Python using a PyObject.
// SelfCallbackTest should be inherited by a Python class.
// Used in test_class.py / testCallback
//==========================================================================
public class SelfCallbackTest
{
public void Callback(Runtime.PyObject self)
{
using (Runtime.Py.GIL())
((dynamic)self).PyCallback(self);
}
}
}
15 changes: 15 additions & 0 deletions src/tests/test_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,21 @@ def testComparisons(self):
c2 = ClassTest()
self.assertRaises(TypeError, lambda: c1 < c2)

def testSelfCallback(self):
""" Test calling back and forth between this and a c# baseclass."""
class CallbackUser(Test.SelfCallbackTest):
def DoCallback(self):
self.PyCallbackWasCalled = False
self.SameReference = False
return self.Callback(self)
def PyCallback(self, self2):
self.PyCallbackWasCalled = True
self.SameReference = self == self2

testobj = CallbackUser()
testobj.DoCallback()
self.assertTrue(testobj.PyCallbackWasCalled)
self.assertTrue(testobj.SameReference)

class ClassicClass:
def kind(self):
Expand Down
0