set unbuffered_active = False before error raise #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Sep 12, 2019
pymysql/protocol.py
Outdated
| err.raise_mysql_exception(self._data) | ||
| self.raise_error() | ||
|
|
||
| def raise_error(self): |
There was a problem hiding this comment.
Suggested change
| def raise_error(self): | |
| def raise_for_error(self): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While SSCursor closing for recieved a ERROR packet, the client try to _finish_unbuffered_query because
unbuffered_activeis still True, but the server would not send packets anymore.