bugfix

PyMySQL · methane · Jun 26, 2018 · Jun 22, 2017 · Jun 8, 2018 · Jun 8, 2018
commit 6d993320daba46eb8c0b389c3a8d8d7221a1ae23
diff --git a/pymysql/_auth.py b/pymysql/_auth.py
@@ -121,7 +121,7 @@ def _xor_password(password, salt):
     salt_len = len(salt)
     for i in range(len(password_bytes)):
         password_bytes[i] ^= salt[i % salt_len]
-    return password_bytes
+    return bytes(password_bytes)
 
 
 def sha2_rsa_encrypt(password, salt, public_key):

diff --git a/pymysql/connections.py b/pymysql/connections.py
@@ -887,9 +887,9 @@ def _process_auth(self, plugin_name, auth_packet):
                     raise err.OperationalError(2059, "Authentication plugin '%s'"
                               " not loaded: - %r missing authenticate method" % (plugin_name, type(handler)))
         if plugin_name == b"caching_sha2_password":
-            data = _auth.caching_sha2_password_auth(self, auth_packet)
+            return _auth.caching_sha2_password_auth(self, auth_packet)
         elif plugin_name == b"sha256_password":
-            data = _auth.sha256_password_auth(self, auth_packet)
+            return _auth.sha256_password_auth(self, auth_packet)
         elif plugin_name == b"mysql_native_password":
             data = _auth.scramble_native_password(self.password, auth_packet.read_all())
         elif plugin_
8000
name == b"mysql_old_password":

diff --git a/runtests.py b/runtests.py
@@ -3,6 +3,10 @@
 
 from pymysql._compat import PYPY, JYTHON, IRONPYTHON
 
+#import pymysql
+#pymysql.connections.DEBUG = True
+#pymysql._auth.DEBUG = True
+
 if not (PYPY or JYTHON or IRONPYTHON):
     import atexit
     import gc