8000 Annotate type and set self.connection to None in MySQLResult.read as … by tonal · Pull Request #387 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]
Skip to content

Annotate type and set self.connection to None in MySQLResult.read as … #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2016
Merged

Annotate type and set self.connection to None in MySQLResult.read as … #387

merged 2 commits into from
Jan 7, 2016

Conversation

tonal
Copy link
@tonal tonal commented Oct 23, 2015

…other methods

methane
methane reviewed Oct 23, 2015
View reviewed changes
pymysql/connections.py
@@ -1117,6 +1117,9 @@ def get_server_info(self):
class MySQLResult(object):

def __init__(self, connection):
"""
@type connection: Connection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer :type connection: Connection syntax.
https://www.jetbrains.com/pycharm/help/type-hinting-in-pycharm.html#d290117e152

methane added a commit that referenced this pull request Jan 7, 2016
@methane
Merge pull request #387 from tonal/master
7dc1817 
Annotate type and set self.connection to None in MySQLResult.read as …
@methane methane merged commit 7dc1817 into PyMySQL:master Jan 7, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonal @methane
0