8000 Make charset="utf8" use utf8mb4. by methane · Pull Request #1127 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]
Skip to content

Make charset="utf8" use utf8mb4. #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2023
Merged

Make charset="utf8" use utf8mb4. #1127

merged 2 commits into from
Jun 15, 2023

Conversation

methane
Copy link
Member
@methane methane commented Jun 14, 2023 •
edited
Loading

Use charset="utf8mb3" to use utf8mb3 instead.

Fix #1126

methane added 2 commits June 15, 2023 03:38
@methane
Make charset="utf8" use utf8mb4.
ee1cc64 
Use charset="utf8mb3" to use utf8mb3.
@methane
black
715974f
@codecov
Copy link
codecov bot commented Jun 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08 ⚠️

Comparison is base (f4c348f) 86.30% compared to head (715974f) 86.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   86.30%   86.23%   -0.08%     
==========================================
  Files          17       17              
  Lines        2432     2434       +2     
  Branches      256      257       +1     
==========================================
  Hits         2099     2099              
- Misses        246      249       +3     
+ Partials       87       86       -1
Impacted Files Coverage Δ
pymysql/charset.py 96.13% <100.00%> (-1.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@methane methane merged commit c3a12f6 into PyMySQL:main Jun 15, 2023
@methane methane deleted the utf8mb3 branch June 15, 2023 04:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to use utf8mb3
1 participant
@methane
0