8000 Add `collation` option and `set_character_set()` to Connection by methane · Pull Request #1119 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]

Skip to content

Add collation option and set_character_set() to Connection #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and 8000 privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2023

Conversation

methane
Copy link
Member
@methane methane commented May 24, 2023

Send SET NAMES on every new connection to ensure charset/collation are correctly configured.

Fix #1092

@methane methane added this to the v1.1 milestone May 24, 2023
@codecov
Copy link
codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.04 ⚠️

Comparison is base (103004d) 86.10% compared to head (1d81ded) 86.07%.

❗ Current head 1d81ded differs from pull request most recent head 9c38074. Consider uploading reports for the commit 9c38074 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   86.10%   86.07%   -0.04%     
==========================================
  Files          17       17              
  Lines        2426     2434       +8     
  Branches      256      257       +1     
==========================================
+ Hits         2089     2095       +6     
- Misses        248      249       +1     
- Partials       89       90       +1     
Impacted Files Coverage Δ
pymysql/connections.py 77.81% <80.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@methane methane changed the title Add collation option and set_character_set() to Connection. Add collation option and set_character_set() to Connection May 24, 2023
@methane methane merged commit 6929092 into PyMySQL:main May 24, 2023
@methane methane deleted the set-collation branch May 24, 2023 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default encoding for utf8mb4 and mysql 8 or allow setting encoding when connecting
1 participant
0