8000 Cursor.fetchall() always return list. by methane · Pull Request #1115 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]

Skip to content

Cursor.fetchall() always return list. #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy st 8000 atement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023

Conversation

methane
Copy link
Member
@methane methane commented May 24, 2023

Cursor.fetchmany() returns empty tuple when exhausted all rows.
It is for Django compatibility.

Fix #1042.

methane added 2 commits May 24, 2023 22:32
Cursor.fetchmany() returns empty tuple when exhausted all rows.
It is for Django compatibility.
@codecov
Copy link
codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.12 ⚠️

Comparison is base (9228700) 86.30% compared to head (d7c3c20) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   86.30%   86.19%   -0.12%     
==========================================
  Files          17       17              
  Lines        2432     2434       +2     
  Branches      254      255       +1     
==========================================
- Hits         2099     2098       -1     
- Misses        247      248       +1     
- Partials       86       88       +2     
Impacted Files Coverage Δ
pymysql/cursors.py 83.51% <33.33%> (-0.97%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@methane methane merged commit bfbc6a5 into PyMySQL:main May 24, 2023
@methane methane deleted the fetchall-empty-list branch May 24, 2023 15:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cursor.fetchall() returns a tuple on empty result
1 participant
0