8000 converters module missing import of ProgrammingError · Issue #878 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]
Skip to content

converters module missing import of ProgrammingError #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhearne-usgs opened this issue Jul 27, 2020 · 0 comments · Fixed by #879
Closed

converters module missing import of ProgrammingError #878

mhearne-usgs opened this issue Jul 27, 2020 · 0 comments · Fixed by #879

Comments

@mhearne-usgs
Copy link

Describe the bug
converters module is missing an import of ProgrammingError. You should be able to fix this by adding from .err import ProgrammingError at the top of the converters module.

To Reproduce
Complete steps to reproduce the behavior:

Try to insert a NaN or Inf value into a table.

Expected behavior
A clear error message should appear - instead I got a stack dump on the raise Exception line:

https://github.com/PyMySQL/PyMySQL/blob/master/pymysql/converters.py#L58

Environment

  • OS: [e.g. Windows, Linux]
  • Server and version: [e.g. MySQL 8.0.19, MariaDB]
  • PyMySQL version:

Additional context
Add any other context about the problem here.
methane added a commit to methane/PyMySQL that referenced this issue Jul 28, 2020
@methane
Add missing import
97db9ac 
Fixes PyMySQL#878
@methane methane mentioned this issue Jul 28, 2020
Merged
methane added a commit that referenced this issue Jul 28, 2020
@methane
Add missing import (#879)
3e71dd3 
Fixes #878
This was referenced Mar 12, 2021
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing import methane/PyMySQL
1 participant
@mhearne-usgs
0