8000 Test failures with MySQL 5.7 in Ubuntu Xenial and Yakkety · Issue #478 · PyMySQL/PyMySQL · GitHub
[go: up one dir, main page]
Skip to content

Test failures with MySQL 5.7 in Ubuntu Xenial and Yakkety #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ltangvald opened this issue Jun 28, 2016 · 4 comments
Closed

Test failures with MySQL 5.7 in Ubuntu Xenial and Yakkety #478

ltangvald opened this issue Jun 28, 2016 · 4 comments

Comments

@ltangvald
Copy link

At https://github.com/PyMySQL/PyMySQL/blob/master/pymysql/tests/test_issues.py#L460 (and 470)
the test checks for python version > 3.2 and MySQL version to see if it should expect the deprecation warning 5.7 will give for the statement. However, this warning is also thrown when running the test with python 2.7, causing the test to fail when building the python-pymysql package in Ubuntu Xenial and Yakkety.
Ubuntu Launchpad bug: https://bugs.launchpad.net/ubuntu/+source/python-pymysql/+bug/1592664

Suggested fix

Simply removing the check on python version seems to fix the issue.
@methane
Copy link
Member
methane commented Jun 28, 2016

thanks

methane added a commit that referenced this issue Jun 28, 2016
@methane
Merge pull request #479 from methane/fix/478
a03d740 
fix #478
@ltangvald
Copy link
Author

The code on line 470 has the same issue, though (AsText and AsBinary are both deprecated)

@methane methane reopened this Jun 29, 2016
@methane
Copy link
Member
methane commented Jun 29, 2016

@ltangvald I'm sorry about it.
Do you really need release?

I don't want to make a new release only for test failure on certain environment,
without real bugfix in library code.

@ltangvald
Copy link
Author

@methane For the Ubuntu package we can fix it with a patch in the packaging scripts (which refers to this bug so we can keep track of when it's fixed upstream), so you don't need to rush it :)

methane added a commit that referenced this issue Jul 13, 2016
@methane
Merge pull request #485 from methane/fix/478
2525d0a 
fix #478 again
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@methane @ltangvald
0