Fix deserialization of authorizations with multiple transitions #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find!
Yes please. You can see some recent examples of adjusted tests in |
|
@vicsn this is good for another pass! added unit tests |
niklaslong
reviewed
Feb 19, 2025
| // Ensure the requests and transitions are in order. | ||
| for (index, (request, transition)) in requests.iter().zip_eq(&transitions).enumerate() { | ||
| for (index, (request, transition)) in requests_deque.iter().zip_eq(&transitions).enumerate() { |
There was a problem hiding this comment.
I'm not yet familiar with the full context behind this change (it's rather odd these are not ordered the same way by default) but just looking at the rust, you could probably do something like this to avoid building a second VecDeque and calling clone, pop and insert:
Suggested change
| for (index, (request, transition)) in requests_deque.iter().zip_eq(&transitions).enumerate() { | |
| for (index, (request, transition)) in requests.iter().skip(1).chain(requests.iter().take(1)).zip_eq(&transitions).enumerate() { |
|
@niklaslong thanks for the feedback! it's been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When deserializing an
Authorizationfrom string a call stack that included multiple transitions, the structural assertion logic would erroneously fail. This PR fixes the assertion logic but does not change the underlying structure/order of theAuthorizationfields.Test Plan
Added two unit tests for authorization deserializations:
synthesizer/process/src/stack/authorization/mod.rssynthesizer/src/vm/mod.rsI'm happy to relocate the latter to
authorization/mod.rsbut stuck it invm/mod.rssince it needs to deploy two programs to the test VM.Related PRs
none