8000 added missing PureBasic keyword and fixed constants with $ at the end by HeX0R101 · Pull Request #3320 · PrismJS/prism · GitHub
[go: up one dir, main page]
Skip to content

added missing PureBasic keyword and fixed constants with $ at the end #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

added missing PureBasic keyword and fixed constants with $ at the end #3320

merged 2 commits into from
Feb 3, 2022

Conversation

HeX0R101
Copy link
Contributor
@HeX0R101 HeX0R101 commented Feb 3, 2022

Added missing keyword "ForEver" and constants with a $ at the end (e.g. #NULL$) were shown wrong.

@github-actions
Copy link
github-actions bot commented Feb 3, 2022 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +6 B (+0.5%).

file master pull size diff % diff
components/prism-purebasic.min.js 1.13 KB 1.13 KB +6 B +0.5%

Generated by 🚫 dangerJS against c7e5716

@HeX0R101 HeX0R101 force-pushed the fix_purebasic branch 2 times, most recently from 72536b0 to dfca07f Compare February 3, 2022 20:40
@HeX0R101
Copy link
Contributor Author
HeX0R101 commented Feb 3, 2022

Sorry for all those force-pushings, I didn't touch prism for a long time, seems I forgot how to do things right.
Got it now (I think)

@RunDevelopment
Copy link
Member

Thank you for the PR @HeX0R101!

Could please you also add a test for constants with a $ at the end?

Sorry for all those force-pushings

Don't worry about it :)

@HeX0R101
Copy link
Contributor Author
HeX0R101 commented Feb 3, 2022

Done!

@RunDevelopment RunDevelopment merged commit d6c5372 into PrismJS:master Feb 3, 2022
@HeX0R101 HeX0R101 deleted the fix_purebasic branch February 4, 2022 08:31
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

56B4 RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeX0R101 @RunDevelopment
0