Add MailKit and MimeKit as trusted assemblies#27
Closed
ThreeFive-O wants to merge 1 commit intoPowerShell:masterfrom
ThreeFive-O:TrustedAssemblies-MailKit
Closed
Add MailKit and MimeKit as trusted assemblies#27ThreeFive-O wants to merge 1 commit intoPowerShell:masterfrom ThreeFive-O:TrustedAssemblies-MailKit
ThreeFive-O wants to merge 1 commit intoPowerShell:masterfrom
ThreeFive-O:TrustedAssemblies-MailKit
Conversation
Member
|
It would also need |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds MailKit and MimeKit as trusted assemblies in remoting scenarios
As per comment of @TravisEz13 in PowerShell/PowerShell#10246
Context
PR PowerShell/PowerShell#10246 is a rework of the Send-MailMessage cmdlet which intends to use the external dependencies MailKit and MimeKit.
The CI in PowerShell main repo fails right now, as MailKit.dll and MimeKit.dll are not yet registered as trusted. This PR intends to fix this.
@adityapatwardhan Could you please tell me if there are any other necessary changes to the code required to make the DLLs as trusted?
Once this PR is complete, would it be possible to pre-release PowerShell-Native, and merge the updated dependency in PowerShell as suggested by @TravisEz13?