Multiple test fixes and improved logging for fragile tests#9569
Merged
adityapatwardhan merged 17 commits intoPowerShell:masterfrom May 10, 2019
Merged
Multiple test fixes and improved logging for fragile tests#9569adityapatwardhan merged 17 commits intoPowerShell:masterfrom
adityapatwardhan merged 17 commits intoPowerShell:masterfrom
Conversation
JamesWTruher
reviewed
May 8, 2019
Collaborator
There was a problem hiding this comment.
just nits and a typo. Should probably fix the typo
test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
@adityapatwardhan, your last commit had 1 failures in Expected an exception, with FullyQualifiedErrorId 'UnauthorizedAccess,Microsoft.PowerShell.Commands.ImportModuleCommand' to be thrown, but no exception was thrown.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Security\ExecutionPolicy.Tests.ps1: line 688
688: $testScript | Should -Throw -ErrorId $expectedError |
Member
Author
|
@JamesWTruher I have addressed your comments. Please have another look. |
TravisEz13
reviewed
May 9, 2019
TravisEz13
reviewed
May 9, 2019
test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1
Outdated
Show resolved
Hide resolved
TravisEz13
approved these changes
May 9, 2019
TravisEz13
approved these changes
May 10, 2019
Member
|
Does this need to be back ported? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
Fix multiple test failures found while running release automation tests on multiple platforms.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.