8000 Add wildcard back to end of tab completion command lookup by TylerLeonhardt · Pull Request #9383 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add wildcard back to end of tab completion command lookup#9383

Merged
TravisEz13 merged 3 commits intomasterfrom
missed-completions-testcase
Apr 18, 2019
Merged

Add wildcard back to end of tab completion command lookup#9383
TravisEz13 merged 3 commits intomasterfrom
missed-completions-testcase

Conversation

@TylerLeonhardt
Copy link
Member
@TylerLeonhardt TylerLeonhardt commented Apr 16, 2019

PR Summary

Re-add wildcard when searching AST + Missed test case.

PR Context

In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.

PR Checklist

@SteveL-MSFT
Copy link
Member

@PoshChan please get failures

@PowerShell PowerShell deleted a comment from PoshChan Apr 16, 2019
@PowerShell PowerShell deleted a comment from PoshChan Apr 16, 2019
@PowerShell PowerShell deleted a comment from PoshChan Apr 16, 2019
@PowerShell PowerShell deleted a comment from PoshChan Apr 16, 2019
@TylerLeonhardt
Copy link
Member Author

@PoshChan please get failures

@PoshChan
Copy link
Collaborator

@TylerLeonhardt, your last commit had 1 failures in PowerShell-CI-linux
TabCompletion.Miscellaneous completion tests.Input 'function Get-ScrumData {}; Get-Scrum' should successfully complete

Expected the actual value to be greater than 0, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: line 593
593:             $res.CompletionMatches.Count | Should -BeGreaterThan 0

@PoshChan
Copy link
Collaborator

@TylerLeonhardt, your last commit had 1 failures in PowerShell-CI-macos
TabCompletion.Miscellaneous completion tests.Input 'function Get-ScrumData {}; Get-Scrum' should successfully complete

Expected the actual value to be greater than 0, but got 0.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: line 593
593:             $res.CompletionMatches.Count | Should -BeGreaterThan 0

@PoshChan
Copy link
Collaborator

@TylerLeonhardt, test results were not published for PowerShell-CI-static-analysis at vstfs:///Build/Build/20699

@PoshChan
Copy link
Collaborator

@TylerLeonhardt, your last commit had 1 failures in PowerShell-CI-windows
TabCompletion.Miscellaneous completion tests.Input 'function Get-ScrumData {}; Get-Scrum' should successfully complete

Expected the actual value to be greater than 0, but got 0.
at <ScriptBlock>, D:\a\1\s\test\powershell\Host\TabCompletion\TabCompletion.Tests.ps1: line 593
593:             $res.CompletionMatches.Count | Should -BeGreaterThan 0

@TylerLeonhardt
Copy link
Member Author

There's the proof

@SteveL-MSFT
Copy link
Member

@TravisEz13 we should take this for next 6.2 servicing release

@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review April 17, 2019 02:58
@TravisEz13 TravisEz13 changed the title Missed test case Add wildcard back to end of tab completion command lookup Apr 17, 2019
@TravisEz13 TravisEz13 added this to the 6.2.1-consider milestone Apr 17, 2019
@TravisEz13 TravisEz13 added the WG-Engine core PowerShell engine, interpreter, and runtime label Apr 17, 2019
@TravisEz13
Copy link
Member

@TylerLeonhardt please review PR name. PR's that change functionality, should be named by the functionality they change.

@TylerLeonhardt
Copy link
Member Author

@TravisEz13 LGTM

@TravisEz13 TravisEz13 merged commit 9140e42 into master 8000 Apr 18, 2019
@TravisEz13 TravisEz13 deleted the missed-completions-testcase branch April 18, 2019 18:42
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 23, 2019
TravisEz13 pushed a commit that referenced this pull request May 13, 2019
Re-add wildcard when searching AST + Missed test case.

## PR Context

In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log WG-Engine core PowerShell engine, interpreter, and runtime

Projects

None yet

Milestone

6.2.1

Development

Successfully merging this pull request may close these issues.

5 participants

0