8000 Create codecoverage and test packages for non-windows by adityapatwardhan · Pull Request #9373 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Create codecoverage and test packages for non-windows#9373

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:NonWindowsCC
Apr 16, 2019
Merged

Create codecoverage and test packages for non-windows#9373
TravisEz13 merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:NonWindowsCC

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Apr 15, 2019

PR Summary

Refactor the ci.psm1 to publish the code coverage and test packages.
Allow CodeCoverage configuration on non-windows.

PR Context

We plan to run code coverage on Windows, Linux and macOS. These changes are needed to unblock those runs.

PR Checklist

@PoshChan
Copy link
Collaborator

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://windowsserver.uservoice.com/forums/301869-powershell should work

retry of URL failed with error: 
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 113
113:                                 throw "retry of URL failed with error: $($_.Message)"

@adityapatwardhan
Copy link
Member Author

@PoshChan please try static

@PoshChan
Copy link
Collaborator

@adityapatwardhan, I do not understand: please try static

Commands available in this repo for you:

  • retry <target> this will attempt to retry only the failed jobs for the target pipeline
  • rebuild <target> this will perform a complete rebuild of the target pipeline, rerun can be used in place of rebuild
    Supported values for <target> which can be a comma separated list are: static,windows,macos,linux,all
  • get failures this will attempt to get the latest failures for all of the target pipelines
  • remind me in <value> <units> this will create a reminder that will be posted after the specified duration
    <value> is a number, and <units> can be minutes, hours, or days (singular or plural)

@adityapatwardhan
Copy link
Member Author

@PoshChan please retry static

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started retry of PowerShell-CI-static-analysis

@PoshChan
Copy link
Collaborator

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-linux
Validate Update-Help from the Web for all PowerShell Core modules..Validate Update-Help for module 'Microsoft.PowerShell.Security' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

@adityapatwardhan
Copy link
Member Author

@PoshChan please retry linux

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started retry of PowerShell-CI-Linux

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 16, 2019
@TravisEz13
Copy link
Member

@adityapatwardhan should this be 6.2.1-consider?

@adityapatwardhan adityapatwardhan added this to the 6.2.1-consider milestone Apr 16, 2019
@adityapatwardhan
Copy link
Member Author

Marked it for 6.2.1-consider

@TravisEz13 TravisEz13 merged commit 3ffd998 into PowerShell:master Apr 16, 2019
@adityapatwardhan adityapatwardhan deleted the NonWindowsCC branch April 16, 2019 22:15
TravisEz13 pushed a commit that referenced this pull request May 13, 2019
Refactor the `ci.psm1` to publish the code coverage and test packages.
Allow `CodeCoverage` configuration on non-windows.

## PR Context

We plan to run code coverage on Windows, Linux and macOS. These changes are needed to unblock those runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0