8000 Move from npm to Yarn for markdown tests by RDIL · Pull Request #9312 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Move from npm to Yarn for markdown tests#9312

Merged
TravisEz13 merged 10 commits intoPowerShell:masterfrom
RDIL:patch-2
Apr 10, 2019
Merged

Move from npm to Yarn for markdown tests#9312
TravisEz13 merged 10 commits intoPowerShell:masterfrom
RDIL:patch-2

Conversation

@RDIL
Copy link
Contributor
@RDIL RDIL commented Apr 6, 2019 •
edited
Loading

PR Summary

Yarn is better because...

  • it validates package checksums
  • it has emojis 🤟
  • it is faster and employs better caching

PR Context

PR Checklist

@RDIL RDIL marked this pull request as ready for review April 7, 2019 00:59
TravisEz13
TravisEz13 reviewed Apr 7, 2019
View reviewed changes
TravisEz13
TravisEz13 reviewed Apr 7, 2019
View reviewed changes
@TravisEz13
Copy link
Member
TravisEz13 commented Apr 7, 2019

@PoshChan Please remind me in 16 hours

@PoshChan
Copy link
Collaborator
PoshChan commented Apr 7, 2019

@TravisEz13, will remind you in 16 hours

@RDIL RDIL changed the title Move from npm to yarn for markdown tests Move from npm to Yarn for markdown tests Apr 8, 2019
@RDIL
Copy link
Contributor Author
RDIL commented Apr 8, 2019

@TravisEz13 this is your 16 hour reminder

@PoshChan
Copy link
Collaborator
PoshChan commented Apr 8, 2019

@TravisEz13, this is the reminder you requested 16 hours ago

@RDIL
Copy link
Contributor Author
RDIL commented Apr 10, 2019

@TravisEz13 ping

@RDIL RDIL mentioned this pull request Apr 10, 2019
Closed
@TravisEz13 TravisEz13 merged commit 2d87948 into PowerShell:master Apr 10, 2019
@RDIL RDIL deleted the patch-2 branch April 10, 2019 21:17
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.1 milestone Apr 11, 2019
@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

No one assigned

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@RDIL @TravisEz13 @PoshChan
0