8000 Verify failures work by TravisEz13 · Pull Request #9306 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Verify failures work #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TravisEz13 wants to merge 4 commits into from
Closed

Verify failures work #9306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
524ca9a
Fix skipping of tests
SteveL-MSFT Apr 5, 2019
3ab9481
Fix execution policy test issues
TravisEz13 Apr 5, 2019
0e8be21
fix null ref error
TravisEz13 Apr 5, 2019
a4a10c5
re-introduce a failure
TravisEz13 Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ ZoneId=$FileType
Get-ExecutionPolicy -Scope LocalMachine | Should -Be "ByPass"
}

It '-Scope LocalMachine is Settable' -Skip:(!(Test-CanWriteToPsHome)) {
It '-Scope LocalMachine is Settable' -Skip:$ShouldSkipTest {
# We need to make sure that both Process and CurrentUser policies are Undefined
# before we can set LocalMachine policy without ExecutionPolicyOverride error.
Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined
Expand Down
8 changes: 4 additions & 4 deletions test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Describe "JEA session Transcript script test" -Tag @("Feature", 'RequireAdminOnW
BeforeAll {
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()

if ( ! $IsWindows )
if ( ! $IsWindows -or !(Test-CanWriteToPsHome))
{
$PSDefaultParameterValues["it:skip"] = $true
}
Expand All @@ -54,7 +54,7 @@ Describe "JEA session Transcript script test" -Tag @("Feature", 'RequireAdminOnW
$global:PSDefaultParameterValues = $originalDefaultParameterValues
}

It "Configuration name should be in the transcript header" -Skip:(!(Test-CanWriteToPsHome)) {
It "Configuration name should be in the transcript header" {
[string] $RoleCapDirectory = (New-Item -Path "$TestDrive\RoleCapability" -ItemType Directory -Force).FullName
[string] $PSSessionConfigFile = "$RoleCapDirectory\TestConfig.pssc"
[string] $transScriptFile = "$RoleCapDirectory\*.txt"
Expand Down Expand Up @@ -82,7 +82,7 @@ Describe "JEA session Get-Help test" -Tag @("CI", 'RequireAdminOnWindows') {
BeforeAll {
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()

if ( ! $IsWindows )
if ( ! $IsWindows -or !(Test-CanWriteToPsHome))
{
$PSDefaultParameterValues["it:skip"] = $true
}
Expand All @@ -96,7 +96,7 @@ Describe "JEA session Get-Help test" -Tag @("CI", 'RequireAdminOnWindows') {
$global:PSDefaultParameterValues = $originalDefaultParameterValues
}

It "Get-Help should work in JEA sessions" -Skip:(!(Test-CanWriteToPsHome)) {
It "Get-Help should work in JEA sessions" {
[string] $RoleCapDirectory = (New-Item -Path "$TestDrive\RoleCapability" -ItemType Directory -Force).FullName
[string] $PSSessionConfigFile = "$RoleCapDirectory\TestConfig.pssc"
try
Expand Down
4 changes: 2 additions & 2 deletions tools/ci.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,8 @@ function Invoke-LinuxTestsCore
$allTestResultsWithNoExpFeature = @($pesterPassThruNoSudoObject, $pesterPassThruSudoObject)
$allTestResultsWithExpFeatures = @($noSudoResultsWithExpFeatures, $sudoResultsWithExpFeatures)
# This throws if there was an error:
$allTestResultsWithNoExpFeature | ForEach-Object { Test-PSPesterResults -ResultObject $_ }
$allTestResultsWithExpFeatures | ForEach-Object { Test-PSPesterResults -ResultObject $_ -CanHaveNoResult }
$allTestResultsWithNoExpFeature | Where-Object {$null -ne $_} | ForEach-Object { Test-PSPesterResults -ResultObject $_ }
$allTestResultsWithExpFeatures | Where-Object {$null -ne $_} | ForEach-Object { Test-PSPesterResults -ResultObject $_ -CanHaveNoResult }
$result = "PASS"
} catch {
# The build failed, set the result:
Expand Down
0