Fix skipping of tests in RemoteSession.Basic.Tests.ps1#9304
Merged
TravisEz13 merged 3 commits intoPowerShell:masterfrom Apr 6, 2019
Merged
Fix skipping of tests in RemoteSession.Basic.Tests.ps1#9304TravisEz13 merged 3 commits intoPowerShell:masterfrom
TravisEz13 merged 3 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Apr 5, 2019
Member
|
rebased the branch so all the failures will show up. |
Member
|
@SteveL-MSFT there are still failures in these other tests: |
Member
Author
|
@TravisEz13 I'll review the tests from the other PR to make sure they are all covered |
Collaborator
|
@TravisEz13, your last commit had 2 failures in Operation is not supported on this platform.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1163
1163: Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined
Validate Set-ExecutionPolicy -Scope (Admin).-Scope LocalMachine is Settable Operation is not supported on this platform.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1175
1175: Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined
|
11 tasks
Member
TravisEz13
added a commit
that referenced
this pull request
Apr 15, 2019
Moved check if able to write to $PSHome as way to skip test to `BeforeAll` which already contained a check if running on Windows. ## PR Context As part #9279, tests were updated to be skipped if the test requires writing to `$PSHome` but is not able to. However, these tests already had a skip mechanism in place so the additional check caused the test to run when it should have skipped. Co-authored-by: Travis Plunk <github@ez13.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Moved check if able to write to $PSHome as way to skip test to
BeforeAllwhich already contained a check if running on Windows.PR Context
As part #9279, tests were updated to be skipped if the test requires writing to
$PSHomebut is not able to. However, these tests already had a skip mechanism in place so the additional check caused the test to run when it should have skipped.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.