Move artifacts to artifact staging directory before uploading#9273
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Apr 2, 2019
Merged
Move artifacts to artifact staging directory before uploading#9273adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
TravisEz13
approved these changes
Apr 2, 2019
Collaborator
|
@adityapatwardhan, your last commit had 1 failures in Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Api\TaskBasedAsyncPowerShellAPI.Tests.ps1: line 213
213: $ir.IsFaulted | Should -Be $true |
Member
Author
|
@PoshChan Please retry windows |
Collaborator
|
@adityapatwardhan, successfully started retry of |
Member
Author
|
Merged this without waiting for 24 hours as this fixes the daily build break. |
TravisEz13
pushed a commit
that referenced
this pull request
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Artifact upload is asynchronous task and hence the file path needs to be valid for much longer. During build we occasionally clean the build directory and then the built artifacts are deleted. This change moves the artifacts to artifact staging directory and then issues an upload request from that path.
PR Context
Fixing daily build failure.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.