8000 Add secret scanning to CI by TravisEz13 · Pull Request #9249 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add secret scanning to CI#9249

Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom
TravisEz13:Add_credscan
Mar 30, 2019
Merged

Add secret scanning to CI#9249
TravisEz13 merged 8 commits intoPowerShell:masterfrom
TravisEz13:Add_credscan

Conversation

@TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Mar 29, 2019

PR Summary

Add secret scanning to CI

PR Context

This should prevent us from having any secrets in our history

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review March 29, 2019 20:02
Copy link
Contributor
@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13

This comment has been minimized.

@PoshChan

This comment has been minimized.

@TravisEz13
Copy link
Member Author

@PoshChan Please remind me in 24 hours

@PoshChan
Copy link
Collaborator

@TravisEz13, will remind you in 24 hours

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 29, 2019
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 29, 2019
@TravisEz13 TravisEz13 merged commit 14980aa into PowerShell:master Mar 30, 2019
@TravisEz13 TravisEz13 deleted the Add_credscan branch March 30, 2019 17:17
@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 24 hours ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0