Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings#9247
Merged
adityapatwardhan merged 28 commits intoPowerShell:masterfrom Apr 11, 2019
Merged
Conversation
…st for including a quote character fails, as illegal characters are in the path
11 tasks
iSazonov
reviewed
Mar 29, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
…ked by get-alias instead of executing the alias, which is a cleaner method to check whether the alias is imported correctly
iSazonov
reviewed
Mar 30, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
…e is present. The tests should now pass
Contributor
Author
|
We should now be able to safely delete |
iSazonov
reviewed
Mar 31, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I accidently commited the content of #9091 branch into this branch. I'll try to undo it
apparently this happened during the accidental merge due to code ownership. Although I fixed that the commits were reverted, I don't know if this request for review is a problem of any kind. |
0e7b95f to
d2f1311
Compare
…alid file, it now creates a new file only containing the invalid alias
Contributor
Author
|
All suggestions are implemented,thanks @iSazonov. |
SteveL-MSFT
requested changes
Apr 2, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
iSazonov
reviewed
Apr 3, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@SteveL-MSFT I implemented all your suggestions |
iSazonov
approved these changes
Apr 4, 2019
Collaborator
There was a problem hiding this comment.
@SytzeAndr Thanks for fixing all style issues in the old file!
adityapatwardhan
requested changes
Apr 8, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>
Collaborator
|
@adityapatwardhan Could you please update your review? |
adityapatwardhan
approved these changes
Apr 11, 2019
Member
|
@SytzeAndr Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
According to this comment by daxian-dbw,
"abc""def"should be parsed toabc"def. This was not covered in the old test cases, but should be now with this PR.This PR adds tests for the
import-aliasby file, in a seperate PR as discussed in #9091. After this gets accepted, it should be possible to start refactoringimport-alias. Details about this refactorization can be found in #9091 .This pr adds the following test cases for import alias by file:
"abc""def"should parse toabc"def"aaa"should parse toaaa"a,b"should parse toa,bIf more exhaustive testing is required, please let me know.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.