8000 Add timestamp to pshost trace listener by SteveL-MSFT · Pull Request #9230 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add timestamp to pshost trace listener#9230

Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:trace-timestamp
Apr 1, 2019
Merged

Add timestamp to pshost trace listener#9230
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:trace-timestamp

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Mar 26, 2019 •
edited
Loading

PR Summary

Insert timestamp to the beginning of the trace. Looks like:

DEBUG: 2019-03-26 10:52:35.4088 SessionState Information: 0 :  WriteLine   Drive found in scope 0
DEBUG: 2019-03-26 10:52:35.4090 LocationGlobber Information: 0 :  WriteLine   path = Users/steve/repos/PowerShell
DEBUG: 2019-03-26 10:52:35.4091 CmdletProviderClasses Information: 0 :  WriteLine   basePath = /
DEBUG: 2019-03-26 10:52:35.4093 CmdletProviderClasses Information: 0 :  WriteLine   tokenizedPathStack.Push(PowerShell)

PR Context

When using Trace-Command with -PSHost, you don't get timestamp traces. This can be useful to determine where the command/expression is spending its time.

PR Checklist

@SteveL-MSFT SteveL-MSFT mentioned this pull request Mar 26, 2019
Closed
@adityapatwardhan
Copy link
Member
adityapatwardhan commented Mar 29, 2019

@SteveL-MSFT can you respond the @iSazonov comment.

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Apr 1, 2019

@PoshChan Please restart static-analysis

@PoshChan

This comment has been minimized.

Sign in to view
@adityapatwardhan

This comment has been minimized.

Sign in to view
@PoshChan

This comment has been minimized.

Sign in to view
@adityapatwardhan
Copy link
Member
adityapatwardhan commented Apr 1, 2019

@PoshChan Please rerun staging

@PoshChan
Copy link
Collaborator
PoshChan commented Apr 1, 2019

@adityapatwardhan, did not find matching build context: PowerShell-CI-static-analysis; allowed contexts: PowerShell-CI-linux, PowerShell-CI-macos, PowerShell-CI-windows

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Apr 1, 2019

@PoshChan Please retry staging

@PoshChan
Copy link
Collaborator
PoshChan commented Apr 1, 2019

@adityapatwardhan, did not find matching build context: PowerShell-CI-static-analysis; allowed contexts: PowerShell-CI-linux, PowerShell-CI-macos, PowerShell-CI-windows

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Apr 1, 2019

@SteveL-MSFT for Posh-Chan bot issue.

@adityapatwardhan adityapatwardhan merged commit 8a0ecaf into PowerShell:master Apr 1, 2019
@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 1, 2019
@adityapatwardhan adityapatwardhan added this to the 6.3.0-preview.1 milestone Apr 1, 2019
@SteveL-MSFT SteveL-MSFT deleted the trace-timestamp branch April 2, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @adityapatwardhan @PoshChan @iSazonov
0