E52E Update Support_Question.md by vexx32 · Pull Request #9218 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update Support_Question.md#9218

Merged
TravisEz13 merged 3 commits intoPowerShell:masterfrom
vexx32:patch-1
Apr 30, 2019
Merged

Update Support_Question.md#9218
TravisEz13 merged 3 commits intoPowerShell:masterfrom
vexx32:patch-1

Conversation

@vexx32
Copy link
Collaborator
@vexx32 vexx32 commented Mar 24, 2019

Update community links in the Support issue template.
Using the join links ensures that new users can get access as intended, rather than only allowing access for existing users.

PR Summary

PR Context

PR Checklist

Update community links in the Support issue template.
Using the join links ensures that new users can get access as intended, rather than only allowing access for existing users.
## Community Resources

[Slack Community Chat](https://powershell.slack.com) - Interactive chat with other PowerShell enthusiasts
[Slack](https://j.mp/psslack) and [Discord](https://j.mp/psdiscord) Community Chat - Interactive chat with other PowerShell enthusiasts. Both Slack and Discord are bridged via a bot and can seamlessly talk to each other.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using bitly?

Copy link
Collaborator Author
@vexx32 vexx32 Mar 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing link is not the join link. It simply links to the Slack space and does not allow new users to join it or view it.

The bitly links are easier to remember and both link to semi-permanent join links for each channel. On occasion these links have had to change, so having the shortlink that can be updated is a lot easier than updating the direct links everywhere they're posted.

If you guys would rather create an aka.ms link, you're more than welcome to! 😄

I think these links are maintained by @Jaykul, to the best of my knowledge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these two chat channels are community maintained and not Microsoft, I would not create aka.ms links to them. if we can confirm that Joel Bennett or some MVP is maintaining those links, I'd be more comfortable using them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can have the long url at the bottom of the doc and ref the link that way so that the markdown is still readable as just text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveL-MSFT so I'm not against that, but the link currently in this document is unusable by anyone who's not already joined the slack space.

If we want to do that, we'd need the actual join link here (which I guess we can get from the shortlink either way).

@Jaykul, you're maintaining that shortlink, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vexx32 yes, I was suggesting using the resolved long url and to put it at the bottom of the doc to not impede readability since it's not made for human consumption

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, looks like @TylerLeonhardt beat us to it, I didn't realize there were aka.ms versions already:

https://aka.ms/psdiscord https://aka.ms/psslack

I guess we'll use these instead then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get @joeyaiello's take on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone wants to maintain an aka.ms link for this from our side, so the fully qualified links are probably the way to go (anchored at the bottom, as @SteveL-MSFT suggested). It's going to be easier for everyone to spot and fix the breakage here than if they have to track down @TylerLeonhardt to get the aka.ms updated.

And yeah, we shouldn't ship bit.ly links we don't own for security reasons.

@stale
Copy link
stale bot commented Apr 23, 2019

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added Stale and removed Stale labels Apr 23, 2019
Copy link
Member
@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add link-refs for readability
@TravisEz13
Copy link
Member

Manually queued static analysis since it didn't trigger: https://powershell.visualstudio.com/PowerShell/_build/results?buildId=21528

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour.

@PoshChan
Copy link
Collaborator

@TravisEz13, will remind you in 1 hour.

@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 1 hour. ago

@TravisEz13 TravisEz13 closed this Apr 25, 2019
@TravisEz13 TravisEz13 reopened this Apr 25, 2019
Jaykul added a commit to Jaykul/PowerShell that referenced this pull request Apr 26, 2019
A little birdie told me PowerShell#9218 was having issues with the links.
@SteveL-MSFT
Copy link
Member

@PoshChan please get failures

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, test results were not published for PowerShell-CI-install-ps at vstfs:///Build/Build/21613

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, test results were not published for PowerShell-CI-linux at vstfs:///Build/Build/21611

@PoshChan
Copy link
8000
Collaborator

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell Core modules..Validate Update-Help for module 'Microsoft.PowerShell.Security' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, test results were not published for PowerShell-CI-static-analysis at vstfs:///Build/Build/21609

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, test results were not published for PowerShell-CI-windows at vstfs:///Build/Build/21612

@SteveL-MSFT
Copy link
Member

@PoshChan please retry macos

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, successfully started retry of PowerShell-CI-macOS

@TravisEz13 TravisEz13 merged commit 2cd4a48 into PowerShell:master Apr 30, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.1 milestone May 15, 2019
@TravisEz13 TravisEz13 added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label May 15, 2019
@vexx32 vexx32 deleted the patch-1 branch June 13, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0