Conversation
788183a to
a2e8b19
Compare
|
Looks great! Unelevated tests on all platforms take about 13-14 minutes. Can we split them and run on 2-3 VMs? |
There was a problem hiding this comment.
LGTM, but I agree with Ilya, the unelevated pspester tests would be better off on different VMs for speed
|
@iSazonov We can split them up by folder or another tag. Folder would be easier. |
|
We also need to remove the [feature] tag code. It causes problems and isn't needed after this PR. I'll do it in another PR... |
|
@TravisEz13 I’ll take care of it after this is merged. |
It seems we need to put the list in a config file to load-balance VMs. |
|
@iSazonov That might work... the script would need to see if any folders had been added and run those on some machine designated as a primary machine |
|
Interesting, can these machines interact so as to receive a test batch from a controller VM and return a report? This would solve the load-balancing problem. And we could use this for remoting tests. |
|
@iSazonov Interactions between the machines may work sometimes but not consistently. The machines are only given private IP Addresses and are not guaranteed to be on the same subnet. I don't think we need that complexity. It's not needed to create a solution. The added complexity would add failure cases. A simpler solution does mean that we would need to manually rebalance occasionally, but I don't think that is a problem. |
|
Come on @PoshChan you are nitpicking the letter case 😆 |
|
@PoshChan Please remind me in 3 hours |
|
@TravisEz13, all requests start with the magic word |
Make the Linux CI build once and then run the tests on 4 different machines, by tag. ## PR Context Running in parallel allows us to run all tests in about the same amount of clock time
PR Summary
Make the Linux CI build once and then run the tests on 4 different machines, by tag.
PR Context
Running in parallel allows us to run all tests in about the same amount of clock time
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests