Typo in n 8000 ew parameter set#9205
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Mar 25, 2019
Merged
Conversation
SteveL-MSFT
approved these changes
Mar 23, 2019
Collaborator
|
@TylerLeonhardt Please add a reference to PR where we made the typo. Also can we cover this by tests? |
Member
Author
|
Updated the PR description. I don't think we really need a test to make sure the parametersets are spelled correctly. I don't think that's something we've done much in the past. I found the typo while I was working on the docs for the original feature and working on the docs offered a good opportunity to double check parametersets and other things are spelled correctly. |
Collaborator
|
@TylerLeonhardt Thanks for fixing the typo. I'll merge on next week. |
Collaborator
|
I wonder that 4 reviewers (I too) skipped this in previous PR. |
daxian-dbw
approved these changes
Mar 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Realized there was a typo in my parameter set name...
Originally added in #8889
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.pwshandEnter-PSHostProcessMicrosoftDocs/PowerShell-Docs#3755[feature]to your commit messages if the change is significant or affects feature tests