Refactor LookupAccountSid P/Invoke in Process.cs #9197
Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom Mar 27, 2019
Merged
Refactor LookupAccountSid P/Invoke in Process.cs #9197daxian-dbw merged 3 commits intoPowerShell:masterfrom
daxian-dbw merged 3 commits intoPowerShell:masterfrom
Conversation
daxian-dbw
requested changes
Mar 25, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Show resolved
Hide resolved
daxian-dbw
approved these changes
Mar 26, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
First commit. Remove unused code.
Second commit. Using StringBuilder in P/Invoke causes extra allocations and buffer copies. Use stackalloc.
PR Context
Related #9139
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests