Use IL assemblies for NuGet packages to reduce size#9171
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Mar 21, 2019
Merged
Use IL assemblies for NuGet packages to reduce size#9171adityapatwardhan merged 4 commits intoPowerShell:masterfrom
adityapatwardhan merged 4 commits intoPowerShell:masterfrom
Conversation
Member
|
/cc @TylerLeonhardt |
PaulHigin
suggested changes
Mar 20, 2019
PaulHigin
approved these changes
Mar 20, 2019
TravisEz13
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The framework dependent build, builds IL assemblies. This PR uses those assemblies to build the packages. This drastically reduces the nuget package size.
PR Context
We needed RID specific folders earlier due to crossgen. As crossgen'ed assemblies are runtime specific. Now that we are using IL assemblies, we just have
winandunixruntimes as, IL assemblies work on all runtimes. We still needwinandunixdue to differences in source code due to conditional compilation.Same as earlier, native dependencies are pulled in through references in the packages.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests