Fix dependencies of nuget build to wait on DEB uploads to finish#9118
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Mar 11, 2019
Merged
Fix dependencies of nuget build to wait on DEB uploads to finish#9118TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
TravisEz13
approved these changes
Mar 11, 2019
TravisEz13
pushed a commit
that referenced
this pull request
Mar 13, 2019
The NuGet build task should wait on uploads for DEB job to complete. ## PR Context There is a race condition when the build for DEB is completed but the upload has not. If the NuGet build job starts it may not get all the packages needed for building nuget packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The NuGet build task should wait on uploads for DEB job to complete.
PR Context
There is a race condition when the build for DEB is completed but the upload has not. If the NuGet build job starts it may not get all the packages needed for building nuget packages.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests