8000 Clean up static analysis config by RDIL · Pull Request #9113 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Clean up static analysis config#9113

Merged
TravisEz13 merged 9 commits intoPowerShell:masterfrom
RDIL:patch-2
Mar 25, 2019
Merged

Clean up static analysis config#9113
TravisEz13 merged 9 commits intoPowerShell:masterfrom
RDIL:patch-2

Conversation

@RDIL
Copy link
Contributor
@RDIL RDIL commented Mar 11, 2019 •
edited
Loading

PR Summary

PR Context

PR Checklist

@daxian-dbw daxian-dbw added this to the 6.2.0-GA-Consider milestone Mar 11, 2019
TravisEz13
TravisEz13 requested changes Mar 11, 2019
View reviewed changes
@TravisEz13
Copy link
Member
TravisEz13 commented Mar 12, 2019

Windows build is set not to start when only static analysis is changed.

@TravisEz13 TravisEz13 self-assigned this Mar 12, 2019
@RDIL
Copy link
Contributor Author
RDIL commented Mar 12, 2019

Oh that’s why

@TravisEz13
Copy link
Member
TravisEz13 commented Mar 12, 2019

To me it is a bug that they don't report success... The fact that I told it not to run in this case, means everything is good.

daxian-dbw
daxian-dbw reviewed Mar 19, 2019
View reviewed changes
@RDIL
Copy link
Contributor Author
RDIL commented Mar 25, 2019

@TravisEz13 anything blocking?

@TravisEz13 TravisEz13 merged commit 5a53ea0 into PowerShell:master Mar 25, 2019
@RDIL RDIL deleted the patch-2 branch March 25, 2019 23:32
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@RDIL @TravisEz13 @daxian-dbw
0