8000 Add support empty NoteProperty in Group-Object by iSazonov · Pull Request #9109 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add support empty NoteProperty in Group-Object #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Mar 13, 2019
Merged

Add support empty NoteProperty in Group-Object #9109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/ObjectCommandComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,17 @@ public override bool Equals(Object inputObject)
public override int GetHashCode()
{
if (PropertyValue == null)
{
return 0;
}

object baseObject = PSObject.Base(PropertyValue);
IComparable baseObjectComparable = baseObject as IComparable;
if (baseObject == null)
{
return 0;
}

if (baseObjectComparable != null)
if (baseObject is IComparable)
{
return baseObject.GetHashCode();
}
Expand Down
7 changes: 7 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ Describe "Group-Object" -Tags "CI" {
$result['Successful'].ErrorMessage.Count | Should -Be 4
$result['Successful'].ErrorMessage[0] | Should -Be ''
}

It "Should understand empty NoteProperty" {
$result = "dummy" | Select-Object -Property @{Name = 'X'; Expression = {}} | Group-Object X
$result.Count | Should -Be 1
$result[0].Name | Should -Be ""
$result[0].Group | Should -Be '@{X=}'
}
}

Describe "Check 'Culture' parameter in order object cmdlets (Group-Object, Sort-Object, Compare-Object)" -Tags "CI" {
Expand Down
0