8000 csv parser used in import alias refactor by SytzeAndr · Pull Request #9091 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

csv parser used in import alias refactor #9091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SytzeAndr wants to merge 95 commits into from
Closed

csv parser used in import alias refactor #9091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
ff086e5
regex expression to read csv string and ignore quotes
SytzeAndr Mar 8, 2019
232f28e
added reference
SytzeAndr Mar 8, 2019
ff2f734
cleanup and delimiter set included
SytzeAndr Mar 8, 2019
8de7476
code comment issues from CI fixed
SytzeAndr Mar 8, 2019
9fe3089
removed comment that gave CI issues, since it is not really necessary
SytzeAndr Mar 8, 2019
43aa935
removal of toArray and wrong String usage
SytzeAndr Mar 8, 2019
021c631
returns empty collection when conditions met
SytzeAndr Mar 8, 2019
643a759
implementation with reader
SytzeAndr Mar 12, 2019
77a32ea
implementation with reader
SytzeAndr Mar 12, 2019
4724161
codefactor warnings
SytzeAndr Mar 12, 2019
1854f53
more codefactor suggestions
SytzeAndr Mar 12, 2019
d1c90f7
more codefactor suggestions regarding wrongly placed brackets and com…
SytzeAndr Mar 12, 2019
a3573ee
more codefactor regarding brackets
SytzeAndr Mar 12, 2019
823c533
remove commented code
SytzeAndr Mar 12, 2019
6de892f
added a stringbuilder
SytzeAndr Mar 12, 2019
40b7d85
rename for clarity
SytzeAndr Mar 12, 2019
2ca1eec
consistency with brackets
SytzeAndr Mar 12, 2019
229fd2a
Implemented changes @Geweldig suggested
SytzeAndr Mar 13, 2019
23a78b7
iSazonov suggestions implemented
SytzeAndr Mar 13, 2019
8cfa8b2
extra parentheses
SytzeAndr Mar 13, 2019
f4a59ed
old way, adding last string outside of the while loop since the build…
SytzeAndr Mar 13, 2019
a08775e
isinQuotes -> isInQuotes
SytzeAndr Mar 13, 2019
2425933
isInQuotes -> betweenQuotes
SytzeAndr Mar 13, 2019
d693032
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Csv.cs
iSazonov Mar 13, 2019
888479d
betweenQuotes -> inQuotes
SytzeAndr Mar 13, 2019
fa3ee33
Merge branch 'csv_refactor' of https://github.com/Geweldig/PowerShell…
SytzeAndr Mar 13, 2019
5d9dc0a
doesn't escape when two quotes are followed, untill -> until
SytzeAndr Mar 17, 2019
8a0a5b1
(char) before peek() and codefactor bracket warning fix
SytzeAndr Mar 17, 2019
9ec85da
codefactor: new line before comment
SytzeAndr Mar 17, 2019
180f4ae
added more tests regarding parsing difficult aliases. However, the te…
SytzeAndr Mar 29, 2019
674425d
added tests for parsing invalid files: should throw an error
SytzeAndr Mar 29, 2019
5c2835b
iSazonov suggestions for testing: added errorID, asserts are now chec…
SytzeAndr Mar 30, 2019
0b2237b
iSasonov suggestions: adding explicit parameters, fixed type regardin…
SytzeAndr Mar 31, 2019
8013cde
wrong indent fixed
SytzeAndr Mar 31, 2019
d2f1311
removed the initializations and fixed the test for get-alias when non…
SytzeAndr Mar 31, 2019
a1ccb76
iSazonov suggestions about comments, and I renamed some variables
SytzeAndr Mar 31, 2019
ee4d514
reference to variable instead of to a string
SytzeAndr Mar 31, 2019
c17d374
instead of adding the invalid aliases to the content to create an inv…
SytzeAndr Mar 31, 2019
f674fca
first version of an implementation base
SytzeAndr Apr 2, 2019
6719924
removed the unnecessary extra check
SytzeAndr Apr 2, 2019
0b62c83
filepath now according to old implementation
SytzeAndr Apr 2, 2019
e4e8e48
fixed build issue
SytzeAndr Apr 2, 2019
b2e9e6e
remove commented code
SytzeAndr Apr 2, 2019
1988aad
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
dbf0663
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
e33ad15
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
4369b0b
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
122caf3
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
7d58d9a
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
4c52d24
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
e907631
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
21da70c
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
dbfc947
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
7f76418
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
7057b97
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
5d40567
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
SteveL-MSFT Apr 3, 2019
38a2acb
removed the afterAll, tests are now with parameters
SytzeAndr Apr 3, 2019
c03faa8
resolved merge conflicts: checkoing for null one level higher for the…
SytzeAndr Apr 3, 2019
8db2dec
iSazonov suggestions, regarding spacing
SytzeAndr Apr 3, 2019
a98d2b1
replaced all tabs with four spaces
SytzeAndr Apr 3, 2019
d6ea184
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…
adityapatwardhan Apr 10, 2019
fe82633
removed the extra bracket introduced
SytzeAndr Apr 10, 2019
7a19388
The bug was due to checking if the options was None. Apparently optio…
SytzeAndr Apr 10, 2019
d670ef1
codefactor suggestions
SytzeAndr Apr 10, 2019
ce3c15d
more codefactor suggestions
SytzeAndr Apr 10, 2019
aae84f7
codefactor fixes
SytzeAndr Apr 10, 2019
d8cf4d3
codefactor fixes, add extra empty line
SytzeAndr Apr 10, 2019
a1918bf
removal of csv.cs since its functionality is transfered to ImportAlia…
SytzeAndr Apr 10, 2019
4998a71
removed reader, implementation is a for loop again
SytzeAndr Apr 10, 2019
a77ecb9
made some methods static
SytzeAndr Apr 10, 2019
75bab5b
more codefactor regarding spaces and newlines
SytzeAndr Apr 10, 2019
57fdb86
removed spaced codefactor was complaining about
SytzeAndr Apr 10, 2019
cc64a01
removed casts to char
SytzeAndr Apr 10, 2019
a63e2d5
for loop bracket on new line
SytzeAndr Apr 10, 2019
f942dac
moved static methods to the top of the file. Did some renaming regard…
SytzeAndr Apr 10, 2019
a62d599
Merge branch 'master' into csv_refactor
SytzeAndr Apr 23, 2019
939babe
iSazonov suggestions
SytzeAndr Apr 23, 2019
1149236
changed to else if
SytzeAndr Apr 23, 2019
a6d7a3c
Merge branch 'csv_import-alias_tests' into csv_refactor
SytzeAndr Apr 23, 2019
4c2795e
tests are failing locally, I reverted some things but not sure why th…
SytzeAndr May 12, 2019
9cf2619
Merge branch 'master' into csv_refactor
SytzeAndr May 12, 2019
76d1992
failing tests, the problem is that options is checked before the four…
SytzeAndr May 12, 2019
82c882f
changed order of error checking, now tests pass
SytzeAndr May 12, 2019
4ac3f91
got rid of the try catch
SytzeAndr May 12, 2019
cffef01
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Imp…
SytzeAndr May 13, 2019
98538ea
small suggestions fix
SytzeAndr May 13, 2019
e1e9671
reverted alias tests to master version
SytzeAndr May 13, 2019
255dc56
typo in implementation, build broke
SytzeAndr May 13, 2019
d9d8f37
removed unnecessary checks
SytzeAndr May 19, 2019
fe0e253
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Imp…
SytzeAndr Jul 13, 2019
39d9f51
ReadOnlySpan suggestion
SytzeAndr Jul 13, 2019
e521cd1
made methods static
SytzeAndr Jul 13, 2019
27937ef
made methods non static
SytzeAndr Jul 13, 2019
8c59dac
space after if, codefactor issue
SytzeAndr Jul 14, 2019
d13b879
i -> i + 1 in while check
SytzeAndr Jul 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 0 additions & 111 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Csv.cs
View file
Open in desktop

This file was deleted.

Loading
0