Refactor macOS CI so that tests run in parallel#9056
Merged
TravisEz13 merged 12 commits intoPowerShell:masterfrom Mar 11, 2019
Merged
Refactor macOS CI so that tests run in parallel#9056TravisEz13 merged 12 commits intoPowerShell:masterfrom
TravisEz13 merged 12 commits intoPowerShell:masterfrom
Conversation
RDIL
approved these changes
Mar 5, 2019
Contributor
There was a problem hiding this comment.
Looks good so far, just saw this and thought it could be simplified.
tools/ci.psm1
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| Write-Verbose "Tests did not fail! Nice job!" | |
| Write-Verbose "Tests passed! Nice job!" |
ed6ce6a to
d883b25
Compare
fcac26c to
3b766e4
Compare
TravisEz13
commented
Mar 9, 2019
| @@ -0,0 +1,74 @@ | |||
| if($PSVersionTable.PSEdition -ne 'Desktop') | |||
Member
Author
There was a problem hiding this comment.
This is code that other that this imperative code to protect against loading in PowerShell core was just moved from CI.psm1
adityapatwardhan
approved these changes
Mar 11, 2019
.vsts-ci/mac.yml
Outdated
| displayName: Bootstrap | ||
| condition: succeeded() | ||
| - pwsh: | | ||
| dir "$(System.ArtifactsDirectory)\*" -Recurse |
.vsts-ci/templates/nix-test.yml
Outdated
| $options = (Get-PSOptions) | ||
| $rootPath = '$(System.ArtifactsDirectory)\bins' | ||
| $originalRootPath = Split-Path -path $options.Output | ||
| Write-Host "orp- '$originalRootPath'" |
TravisEz13
commented
Mar 11, 2019
TravisEz13
commented
Mar 11, 2019
TravisEz13
added a commit
that referenced
this pull request
Mar 13, 2019
Refactor macOS CI so that tests run in parallel
- Also:
- Fix bootstrap issue where curl was failing for a month (so obviously not needed)
- Change Windows test stages to use PowerShell Core (where we can) to avoid compat issues
## PR Context
This allows running all tests in about the same about of clock time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactor macOS CI so that tests run in parallel
PR Context
This allows running all tests in about the same about of clock time.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests