Cleanup & update ErrorRecord class code style#9021
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom Mar 6, 2019
Merged
Cleanup & update ErrorRecord class code style#9021iSazonov merged 4 commits intoPowerShell:masterfrom
iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Mar 4, 2019
| @@ -1071,13 +1074,7 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte | |||
| /// Is this instance serialized. | |||
| /// </summary> | |||
| /// <value></value> | |||
Collaborator
There was a problem hiding this comment.
Is the tag mandatory? Can we remove it?
Collaborator
Author
There was a problem hiding this comment.
I think it's just automatically added by VS when adding comment XML. I'll remove it. :)
Collaborator
Author
|
@iSazonov there were a few instances where we could use |
iSazonov
approved these changes
Mar 4, 2019
adityapatwardhan
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Cleanup and update ErrorRecord class code style & improve consistency of style across the class.
There are no functional changes to this PR; everything is purely code-style-related. Some private properties were ditched entirely, being easily replaced with simple auto-properties (i.e., they just had a straightforward get/set anyway, and the extra code was adding complexity and nothing else).
PR Context
After speaking with @SteveL-MSFT on Twitter, I intend to implement a Suggestion property to ErrorRecord to replace the current Suggestions system.
Before that, I would like to clean up the ErrorRecord class first.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests