8000 Fix CodeFactor brace style issues in FileSystemProvider by RDIL · Pull Request #8992 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix CodeFactor brace style issues in FileSystemProvid 8000 er#8992

Merged
iSazonov merged 9 commits intoPowerShell:masterfrom
RDIL:patch-10
Feb 28, 2019
Merged

Fix CodeFactor brace style issues in FileSystemProvider#8992
iSazonov merged 9 commits intoPowerShell:masterfrom
RDIL:patch-10

Conversation

@RDIL
Copy link
Contributor
@RDIL RDIL commented Feb 26, 2019 •
edited
Loading

PR Summary

Fix instances of issue The body of the else statement must be wrapped in opening and closing curly brackets.

PR Context

PR Checklist

iSazonov
iSazonov reviewed Feb 26, 2019
View reviewed changes
iSazonov
iSazonov reviewed Feb 26, 2019
View reviewed changes
@RDIL RDIL changed the title Fix codefactor style issues Fix CodeFactor style issues Feb 27, 2019
iSazonov
iSazonov reviewed Feb 27, 2019
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 27, 2019
@iSazonov iSazonov self-assigned this Feb 27, 2019
@iSazonov iSazonov changed the title Fix CodeFactor style issues Fix CodeFactor brace style issues in FileSystemProvider Feb 27, 2019
@iSazonov
Copy link
Collaborator
iSazonov commented Feb 28, 2019

@RDIL Please rebase to pass CI-windows.

@iSazonov
Copy link
Collaborator
iSazonov commented Feb 28, 2019

Please rebase to pass CIs.

@RDIL
Copy link
Contributor Author
RDIL commented Feb 28, 2019

Done. Sorry, was sleeping before.

@iSazonov iSazonov merged commit 4cd6a3b into PowerShell:master Feb 28, 2019
@RDIL RDIL deleted the patch-10 branch February 28, 2019 15:01
@iSazonov
Copy link
Collaborator
iSazonov commented Feb 28, 2019

@RDIL Thanks for your contribution!

Some notes for better productivity:

  • please review your changes before push - it saves reviewer time.
  • fix one style issue:
    • or in all code base (one commit for file or some files - we'll review commit by commit)
    • or by module. It is preferred. I suggest start with Utility module (any changes in Engine is dangerous!)
    • use automation if it possible (script or editor features) to reduce typos.

@RDIL
Copy link
Contributor Author
RDIL commented Feb 28, 2019

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RDIL @iSazonov
0