8000 Remove ArchLinux Dockerfile by RDIL · Pull Request #8990 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Remove ArchLinux Dockerfile#8990

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
RDIL:patch-2
Feb 27, 2019
Merged

Remove ArchLinux Dockerfile#8990
TravisEz13 merged 1 commit intoPowerShell:masterfrom
RDIL:patch-2

Conversation

@RDIL
Copy link
Contributor
@RDIL RDIL commented Feb 26, 2019

PR Summary

The archlinux dockerfile is already in the PowerShell-Docker repo so there doesn't seem to be a need for it to be here.

PR Context

PR Checklist

@TravisEz13
Copy link
Member

Any reason you closed this?

@RDIL
Copy link
Contributor Author
RDIL commented Feb 26, 2019

Had thoughts of mixed reactions

@TravisEz13
Copy link
Member

It should be removed. It is dead code.

@TravisEz13
Copy link
Member

Let's give it a day for review. Ping me and I'll merge it, assuming no other feedback.

@TravisEz13 TravisEz13 added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 26, 2019
@TravisEz13 TravisEz13 self-assigned this Feb 26, 2019
@RDIL RDIL changed the title Remove archlinux dockerfile Remove ArchLinux Dockerfile Feb 27, 2019
@RDIL
Copy link
Contributor Author
RDIL commented Feb 27, 2019

@TravisEz13 24 hour ping

@TravisEz13 TravisEz13 merged commit 21c249d into PowerShell:master Feb 27, 2019
@RDIL RDIL deleted the patch-2 branch February 27, 2019 23:43
@RDIL RDIL mentioned this pull request Feb 28, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0