Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pending#8954
Merged
adityapatwardhan merged 14 commits intoPowerShell:masterfrom Mar 5, 2019
RDIL:patch-1
Merged
Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pending#8954adityapatwardhan merged 14 commits intoPowerShell:masterfrom RDIL:patch-1
adityapatwardhan merged 14 commits intoPowerShell:masterfrom
RDIL:patch-1
Conversation
iSazonov
approved these changes
Feb 22, 2019
Contributor
Author
|
@adityapatwardhan @iSazonov please re-review. |
adityapatwardhan
approved these changes
Feb 25, 2019
Collaborator
|
@RDIL Please look CI-Linux errors. |
Contributor
Author
|
I guess the comment is still right |
Collaborator
|
Yes. |
Member
|
@RDIL Can you add |
Contributor
Author
|
@adityapatwardhan I believe I did it, not sure. |
iSazonov
reviewed
Feb 28, 2019
iSazonov
reviewed
Feb 28, 2019
iSazonov
reviewed
Feb 28, 2019
Contributor
Author
|
Everything is now fixed, ready for review/merge. |
iSazonov
approved these changes
Mar 4, 2019
Member
|
Restarted CI for Linux |
Contributor
Author
|
Thanks |
Member
|
@RDIL can you update the PR description and context please? |
Contributor
Author
|
Sure |
Contributor
Author
|
Done |
Member
|
@RDIL Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Enables the test with the new tag, unmark as pending
PR Context
Enables the check by adding
RequireSudoOnUnixtag toDescribeblockPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests