Enable cross-platform Send-MailMessage tests for CI#8859
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Mar 5, 2019
ThreeFive-O:Fix3950
Merged
Enable cross-platform Send-MailMessage tests for CI#8859adityapatwardhan merged 2 commits intoPowerShell:masterfrom ThreeFive-O:Fix3950
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
ThreeFive-O:Fix3950
Conversation
iSazonov
approved these changes
Feb 11, 2019
Collaborator
There was a problem hiding this comment.
LGTM with one comment.
test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
Outdated
Show resolved
Hide resolved
11 tasks
TravisEz13
approved these changes
Feb 19, 2019
Collaborator
|
@adityapatwardhan Please look the PR. |
11 tasks
adityapatwardhan
requested changes
Mar 1, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
Outdated
Show resolved
Hide resolved
Member
|
@ThreeFive-O The changes looks great, just added a comment for improving performance slightly. Everything else looks good. |
Use NuGet V3 API as package source;
Member
|
@adityapatwardhan Please review #9031 . I think we should still take this PR |
Contributor
Author
|
@adityapatwardhan and @TravisEz13 Not sure why my CLA status is still not reported, but all other checks have passed. |
Member
|
@ThreeFive-O No worries, we got status on this commit: 0686809 |
adityapatwardhan
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #3950
This PR contains a cross-platform SMTP server mockup which allows to run the Send-MailMessage tests on the PowerShell CI system (Azure DevOps pipeline) as well as on local development machines for all supported platforms.
This PR includes:
RequireSudoOnUnixtag as Linux and macOS on CI requires sudo for privileged port 25 (SMTP)PR Context
Before this PR the Send-MailMessage tests run only on local Linux development machines when a local SMTP server is set up and running.
This is rather inconvenient for testing because:
The Azure DevOps pipeline VMs don't have any local SMTP server set up. Therefore the tests for Send-MailMessage are skipped during CI checks.
This PR will provide a way to run the tests on the Azure DevOps pipeline for Windows, Linux and macOS as well on local development machines.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests