Documentation Cleanup#8851
Merged
TravisEz13 merged 18 commits intoPowerShell:masterfrom Mar 5, 2019
RDIL:patch-5
Merged
Conversation
iSazonov
approved these changes
Feb 9, 2019
| When building for multiple architectures, be sure to use the `-clean` switch as cmake will cache the previous run and the wrong compiler will be used to generate the subsequent architectures. | ||
|
|
||
| After that, the binary `pwrshplugin.dll`, its PDB file, and `powershell.core.instrumentation.dll` will be placed under 'src\powershell-win-core'. | ||
| After that, the binary `pwrshplugin.dll`, its PDB file, and `powershell.core.instrumentation.dll` will be placed under `src\powershell-win-core`. |
Collaborator
There was a problem hiding this comment.
Native Components - we need to update the section - native components is not in the repo. Perhaps @adityapatwardhan and @PaulHigin could help.
TravisEz13
requested changes
Feb 9, 2019
| Below is a summary of our approach to handing breaking changes including what kinds of things constitute breaking changes, how we categorize them, and how we decide what we're willing to take. | ||
|
|
||
| Note that these rules only apply to existing stable features that have shipped in a supported release. New features marked as “in preview” that are still under development may be modified from one preview release to the next. These are not considered breaking changes. | ||
| Note that these rules only apply to existing stable features that have shipped in a supported release. New features marked as “in preview” that are still under development may be modified from one preview release to the next. |
Member
There was a problem hiding this comment.
perhaps we should change "in preview" to experimental now that we have that feature
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
sdwheeler
suggested changes
Feb 11, 2019
TravisEz13
approved these changes
Feb 11, 2019
Contributor
Author
|
@sdwheeler please update your review |
sdwheeler
approved these changes
Feb 11, 2019
TravisEz13
approved these changes
Feb 11, 2019
adityapatwardhan
approved these changes
Feb 19, 2019
TravisEz13
approved these changes
Feb 19, 2019
TravisEz13
approved these changes
Feb 25, 2019
Collaborator
|
@TravisEz13 Could you merge? |
Contributor
Author
|
Commenting to make sure stale bot doesn't tag the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Also sorry I had to reuse an old patch branch meaning one of Dongbo's commits is still there
PR Context
Improves parts of documentation.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests