Fixing issue with help progress#8788
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Mar 11, 2019
Merged
Conversation
…help cmdlet had completed.
603bd67 to
b47d587
Compare
Member
|
@powercode Love the change! Could you add some tests? Something like the following. Describe "Testing Get-Help Progress" {
It "Last ProgressRecord should be Completed" {
$j = Start-Job { Get-Help DoesNotExist }
$j | Wait-Job
$j.ChildJobs[0].Progress[-1].RecordType | Should -Be ([System.Management.Automation.ProgressRecordType]::Completed)
}} |
iSazonov
reviewed
Feb 7, 2019
iSazonov
approved these changes
Feb 7, 2019
Collaborator
There was a problem hiding this comment.
LGTM with one style comment.
Collaborator
|
Reopen to restart all CIs (no response). |
adityapatwardhan
requested changes
Mar 5, 2019
| It "Last ProgressRecord should be Completed" { | ||
| $j = Start-Job { Get-Help DoesNotExist } | ||
| $j | Wait-Job | ||
| $j.ChildJobs[0].Progress[-1].RecordType | Should -Be ([System.Management.Automation.ProgressRecordType]::Completed) |
Member
There was a problem hiding this comment.
Please add a Remove-Job $j
Collaborator
There was a problem hiding this comment.
It should be in try-finally.
adityapatwardhan
approved these changes
Mar 11, 2019
Member
|
@powercode Pushed an empty commit to execute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Get-Help cmdlet never calls WriteProgress with a RecordType set to Completed, so the progress is left being rendered even after the Get-Help cmdlet has completed.
The PR is adding a write progress call with recordtype set to Completed.
It also cleans up lots of chains to
this.Context.HelpSystemby extracting a variable.PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests