Cleanup Format-Hex #8683
Merged
Cleanup Format-Hex #8683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Jan 18, 2019
| } | ||
| } | ||
| catch (IOException ioException) | ||
| catch (IOException fileException) |
Collaborator
There was a problem hiding this comment.
It is not always true :-) Please revert.
Collaborator
Author
There was a problem hiding this comment.
CodeFactor complained that the io prefix looks too much like a Hungarian prefix, from memory. Is this simply not a concern?
Collaborator
There was a problem hiding this comment.
We frequently use catch (IOException e).
(I guess we will disable the check.)
iSazonov
approved these changes
Jan 18, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Cleanup for code style prior to #8674
/cc @iSazonov ❤️
PR Context
Format-Hex can use a little love in the style department. Added some XML comments that were missing, tidied up existing ones, and made sure the code style overall is consistent with how we've been doing in recent PRs according to StyleCop and other linters.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests