Fix test for -WorkingDirectory when $PROFILE doesn't exist#8152
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Oct 31, 2018
Merged
Fix test for -WorkingDirectory when $PROFILE doesn't exist#8152adityapatwardhan merged 1 commit intoPowerShell:masterfrom
-WorkingDirectory when $PROFILE doesn't exist#8152adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
11 tasks
4731476 to
fc0a38e
Compare
adityapatwardhan
approved these changes
Oct 31, 2018
| $currentProfile = Get-Content $PROFILE | ||
| } | ||
| else { | ||
| New-Item -ItemType File -Path $PROFILE -Force |
Member
There was a problem hiding this comment.
Suggested change
| New-Item -ItemType File -Path $PROFILE -Force | |
| $null = New-Item -ItemType File -Path $PROFILE -Force |
Member
There was a problem hiding this comment.
Merging as this comment is non-blocking.
Collaborator
There was a problem hiding this comment.
Suggested change
| New-Item -ItemType File -Path $PROFILE -Force | |
| New-Item -ItemType File -Path $PROFILE -Force > $null |
😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Test expected $PROFILE to exist, but doesn't exist on CI systems. Part of the path to $PROFILE doesn't exist so we forcibly create $PROFILE with full path. Add checks if it exists and if not, make sure to remove test $PROFILE.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests