8000 Make a temporary array static to exclude extra allocations by iSazonov · Pull Request #6605 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Make a temporary array static to exclude extra allocations #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Make a temporary array static to exclude extra allocations #6605

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b050b
Make a temporary array static to exclude extra allocations
iSazonov Apr 9, 2018
20866a1
Replace array with 6 if statements
iSazonov Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Replace array with 6 if statements
  • Loading branch information
@iSazonov
iSazonov committed Apr 10, 2018
commit 20866a135d128ba018d81c9c7cc36ad97b57a0bf
36 changes: 22 additions & 14 deletions src/System.Management.Automation/engine/lang/parserutils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,26 +530,34 @@ private static IEnumerable<string> enumerateContent(ExecutionContext context, IS
private static RegexOptions parseRegexOptions(SplitOptions options)
{
RegexOptions result = RegexOptions.None;
foreach (int[] entry in map)
if ((options & SplitOptions.CultureInvariant) != 0)
{
if (((int)options & entry[0]) != 0)
{
result |= (RegexOptions)entry[1];
}
result |= RegexOptions.CultureInvariant;
}
if ((options & SplitOptions.IgnorePatternWhitespace) != 0)
{
result |= RegexOptions.IgnorePatternWhitespace;
}
if ((options & SplitOptions.Multiline) != 0)
{
result |= RegexOptions.Multiline;
}
if ((options & SplitOptions.Singleline) != 0)
{
result |= RegexOptions.Singleline;
}
if ((options & SplitOptions.IgnoreCase) != 0)
{
result |= RegexOptions.IgnoreCase;
}
if ((options & SplitOptions.ExplicitCapture) != 0)
{
result |= RegexOptions.ExplicitCapture;
}

return result;
}

private static readonly int[][] map = {
new int[] { (int)SplitOptions.CultureInvariant, (int)RegexOptions.CultureInvariant },
new int[] { (int)SplitOptions.IgnorePatternWhitespace, (int)RegexOptions.IgnorePatternWhitespace },
new int[] { (int)SplitOptions.Multiline, (int)RegexOptions.Multiline },
new int[] { (int)SplitOptions.Singleline, (int)RegexOptions.Singleline },
new int[] { (int)SplitOptions.IgnoreCase, (int)RegexOptions.IgnoreCase },
new int[] { (int)SplitOptions.ExplicitCapture, (int)RegexOptions.ExplicitCapture },
};

internal static object UnarySplitOperator(ExecutionContext context, IScriptExtent errorPosition, object lval)
{
// unary split does a little extra processing to make
Expand Down
0