Tests syntax correction for module Microsoft.PowerShell.Management

PowerShell · TravisEz13 · Mar 9, 2018 · Mar 2, 2018 · Mar 2, 2018 · Mar 2, 2018
commit ec1292f7bc3e42afa866e3f58faf66f2ee5b33a7
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1
@@ -65,22 +65,22 @@ Describe "Get-ChildItem" -Tags "CI" {
 
         It "Should list hidden files as well when 'Force' parameter is used" {
             $files = Get-ChildItem -path $TestDrive -Force
-            $files | Should -Not -Be $null
+            $files | Should -Not -BeNullOrEmpty
             $files.Count | Should -Be 6
-            $files.Name.Contains($item_F) | Should -Be $true
+            $files.Name.Contains($item_F) | Should -BeTrue
         }
 
         It "Should list only hidden files when 'Hidden' parameter is used" {
             $files = Get-ChildItem -path $TestDrive -Hidden
-            $files | Should -Not -Be $null
+            $files | Should -Not -BeNullOrEmpty
             $files.Count | Should -Be 1
-            $files[0].Name | Should -Be $item_F
+            $files[0].Name | Should -BeExactly $item_F
         }
         It "Should find the hidden file if specified with hidden switch" {
             $file = Get-ChildItem -Path (Join-Path $TestDrive $item_F) -Hidden
             $file | Should -Not -BeNullOrEmpty
             $file.Count | Should -Be 1
-            $file.Name | Should -Be $item_F
+            $file.Name | Should -BeExactly $item_F
         }
 
         It "Should list items in current directory only with depth set to 0" {

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ComputerInfo.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ComputerInfo.Tests.ps1
@@ -1008,7 +1008,7 @@ try {
 
         It "Verify type returned by Get-ComputerInfo" {
             $computerInfo = Get-ComputerInfo
-            $computerInfo | Should -BeOfType Microsoft.PowerShell.Commands.ComputerInfo
+            $computerInfo | Should -BeOfType 'Microsoft.PowerShell.Commands.ComputerInfo'
         }
     }
 

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Content.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Content.Tests.ps1
@@ -36,7 +36,7 @@ Describe "Get-Content" -Tags "CI" {
 
     It "Should return an Object when listing only a single line and the correct information from a file" {
         $content = (Get-Content -Path $testPath)
-        $content | Should -Be $testString
+        $content | Should -BeExactly $testString
         $content.Count | Should -Be 1
         $content | Should -BeOfType "System.String"
     }
@@ -48,40 +48,40 @@ Describe "Get-Content" -Tags "CI" {
     }
 
     It "Should be able to return a specific line from a file" {
-        (Get-Content -Path $testPath2)[1] | Should -Be $secondline
+        (Get-Content -Path $testPath2)[1] | Should -BeExactly $secondline
     }
 
     It "Should be able to specify the number of lines to get the content of using the TotalCount switch" {
         $returnArray    = (Get-Content -Path $testPath2 -TotalCount 2)
-        $returnArray[0] | Should -Be $firstline
-        $returnArray[1] | Should -Be $secondline
+        $returnArray[0] | Should -BeExactly $firstline
+        $returnArray[1] | Should -BeExactly $secondline
     }
 
     It "Should be able to specify the number of lines to get the content of using the Head switch" {
         $returnArray    = (Get-Content -Path $testPath2 -Head 2)
-        $returnArray[0] | Should -Be $firstline
-        $returnArray[1] | Should -Be $secondline
+        $returnArray[0] | Should -BeExactly $firstline
+        $returnArray[1] | Should -BeExactly $secondline
     }
 
     It "Should be able to specify the number of lines to get the content of using the First switch" {
         $returnArray    = (Get-Content -Path $testPath2 -First 2)
-        $returnArray[0] | Should -Be $firstline
-        $returnArray[1] | Should -Be $secondline
+        $returnArray[0] | Should -BeExactly $firstline
+        $returnArray[1] | Should -BeExactly $secondline
     }
 
     It "Should return the last line of a file using the Tail switch" {
-        Get-Content -Path $testPath -Tail 1 | Should -Be $testString
+        Get-Content -Path $testPath -Tail 1 | Should -BeExactly $testString
     }
 
     It "Should return the last lines of a file using the Last alias" {
-        Get-Content -Path $testPath2 -Last 1 | Should -Be $fifthline
+        Get-Content -Path $testPath2 -Last 1 | Should -BeExactly $fifthline
     }
 
     It "Should be able to get content within a different drive" {
         Push-Location env:
         $expectedoutput = [Environment]::GetEnvironmentVariable("PATH");
         { Get-Content PATH } | Should -Not -Throw
-        Get-Content PATH     | Should -Be $expectedoutput
+        Get-Content PATH     | Should -BeExactly $expectedoutput
         Pop-Location
     }
 
@@ -124,9 +124,9 @@ baz
         $expected = 'foo'
 
         $actual = Get-Content -Path $testPath -Tail $tailCount -Encoding $encodingName
-        $actual.GetType() | Should -Be "System.Object[]"
+        $actual | Should -BeOfType "[string]"
         $actual.Length | Should -Be $tailCount
-        $actual[0] | Should -Be $expected
+        $actual[0] | Should -BeExactly $expected
     }
 
     It "should Get-Content with a variety of -Tail and -ReadCount: <test>" -TestCases @(
@@ -226,11 +226,11 @@ baz
 
     It "Should support NTFS streams using -Stream" -Skip:(!$IsWindows) {
         Set-Content -Path $testPath -Stream hello -Value World
-        Get-Content -Path $testPath | Should -Be $testString
-        Get-Content -Path $testPath -Stream hello | Should -Be "World"
+        Get-Content -Path $testPath | Should -BeExactly $testString
+        Get-Content -Path $testPath -Stream hello | Should -BeExactly "World"
         $item = Get-Item -Path $testPath -Stream hello
-        $item | Should -BeOfType System.Management.Automation.Internal.AlternateStreamData
-        $item.Stream | Should -Be "hello"
+        $item | Should -BeOfType 'System.Management.Automation.Internal.AlternateStreamData'
+        $item.Stream | Should -BeExactly "hello"
         Clear-Content -Path $testPath -Stream hello
         Get-Content -Path $testPath -Stream hello | Should -BeNullOrEmpty
         Remove-Item -Path $testPath -Stream hello

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-EventLog.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-EventLog.Tests.ps1
@@ -16,19 +16,19 @@ Describe "Get-EventLog cmdlet tests" -Tags @('CI', 'RequireAdminOnWindows') {
       {$result=Get-EventLog -AsString -ea stop}    | Should -Not -Throw
       $result | Should -Not -BeNullOrEmpty
       ,$result                                     | Should -BeOfType "System.Array"
-      $result -eq "Application"                    | Should -Be "Application"
+      $result                                      | Should -BeExactly "Application"
       $result.Count -ge 3                          | Should -BeTrue
     }
     It "should return a list of eventlog objects when called with -List parameter" -Pending:($True) {
       {$result=Get-EventLog -List -ea stop}        | Should -Not -Throw
       $result | Should -Not -BeNullOrEmpty
       ,$result                                     | Should -BeOfType "System.Array"
       {$logs=$result | Select-Object -ExpandProperty Log}   | Should -Not -Throw
-      $logs -eq "System"                           | Should -Be "System"
+      $logs                                        | Should -BeExactly "System"
       $logs.Count -ge 3                            | Should -BeTrue
     }
     It "should be able to Get-EventLog -LogName Application -Newest 100" -Pending:($True) {
-      {$result=get-eventlog -LogName Application -Newest 100 -ea stop} | Should -Not -Throw
+      {$result=get-eventlog -LogName Application -Newest 100 -ErrorAction stop} | Should -Not -Throw
       $result                                      | Should -Not -BeNullOrEmpty
       $result.Length -le 100                       | Should -BeTrue
       $result[0]                                   | Should -BeOfType "EventLogEntry"
@@ -40,7 +40,7 @@ Describe "Get-EventLog cmdlet tests" -Tags @('CI', 'RequireAdminOnWindows') {
     It "should be able to Get-EventLog -LogName * with multiple matches" -Pending:($True) {
       {$result=get-eventlog -LogName *  -ea stop}  | Should -Not -Throw
       $result                                      | Should -Not -BeNullOrEmpty
-      $result -eq "Security"                       | Should -Be "Security"
+      $result                                      | Should -BeExactly "Security"
       $result.Count -ge 3                          | Should -BeTrue
     }
     It "should throw 'InvalidOperationException' when asked to get a log that does not exist" -Pending:($True) {

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1
@@ -17,7 +17,7 @@ Describe "Get-Item" -Tags "CI" {
     It "Should return the name of the current working directory when a dot is used" {
         $item = Get-Item $PSScriptRoot
         $item | Should -BeOfType 'System.IO.DirectoryInfo'
-        $item.Name | Should -Be (Split-Path $PSScriptRoot -Leaf)
+        $item.Name | Should -BeExactly (Split-Path $PSScriptRoot -Leaf)
     }
 
     It "Should return the proper Name and BaseType for directory objects vs file system objects" {
@@ -33,7 +33,7 @@ Describe "Get-Item" -Tags "CI" {
         # if literalpath is not correct we would see filea.txt
         $item = Get-Item -literalpath "$TESTDRIVE/file[abc].txt"
         @($item).Count | Should -Be 1
-        $item.Name | Should -Be 'file[abc].txt'
+        $item.Name | Should -BeExactly 'file[abc].txt'
     }
 
     It "Should have mode flags set" {
@@ -49,7 +49,7 @@ Describe "Get-Item" -Tags "CI" {
         ${result} = Get-Item "${hiddenFile}" -ErrorAction SilentlyContinue
         ${result} | Should -BeNullOrEmpty
         ${result} = Get-Item -force "${hiddenFile}" -ErrorAction SilentlyContinue
-        ${result}.FullName | Should -Be ${item}.FullName
+        ${result}.FullName | Should -BeExactly ${item}.FullName
     }
 
     Context "Test for Include, Exclude, and Filter" {
@@ -62,22 +62,22 @@ Describe "Get-Item" -Tags "CI" {
         It "Should respect -Exclude" {
             $result = Get-Item "${testBaseDir}/*" -Exclude "file2.txt"
             ($result).Count | Should -Be 1
-            $result.Name | Should -Be "file1.txt"
+            $result.Name | Should -BeExactly "file1.txt"
         }
         It "Should respect -Include" {
             $result = Get-Item "${testBaseDir}/*" -Include "file2.txt"
             ($result).Count | Should -Be 1
-            $result.Name | Should -Be "file2.txt"
+            $result.Name | Should -BeExactly "file2.txt"
         }
         It "Should respect -Filter" {
             $result = Get-Item "${testBaseDir}/*" -Filter "*2*"
             ($result).Count | Should -Be 1
-            $result.Name | Should -Be "file2.txt"
+            $result.Name | Should -BeExactly "file2.txt"
         }
         It "Should respect combinations of filter, include, and exclude" {
             $result = get-item "${testBaseDir}/*" -filter *.txt -include "file[12].txt" -exclude file2.txt
             ($result).Count | Should -Be 1
-            $result.Name | Should -Be "file1.txt"
+            $result.Name | Should -BeExactly "file1.txt"
         }
     }
 

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ItemProperty.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-ItemProperty.Tests.ps1
@@ -11,11 +11,11 @@ Describe "Get-ItemProperty" -Tags "CI" {
     New-Item $testfile -ItemType file -Force
 
     It "Should be able to be called on in the current directory" {
-	$(Get-ItemProperty $PSScriptRoot).Name | Should -Be $currentDirectory
+	$(Get-ItemProperty $PSScriptRoot).Name | Should -BeExactly $currentDirectory
     }
 
     It "Should be able to be called on a parent directory" {
-	(Get-ItemProperty $PSScriptRoot/..).Name | Should -Be $parentDirectory
+	(Get-ItemProperty $PSScriptRoot/..).Name | Should -BeExactly $parentDirectory
     }
 
     It "Should be able to be called on a directory using the path switch" {

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Location.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Location.Tests.ps1
@@ -12,10 +12,10 @@ Describe "Get-Location" -Tags "CI" {
 
     It "Should list the output of the current working directory" {
 
-	(Get-Location).Path | Should -Be $currentDirectory
+	(Get-Location).Path | Should -BeExactly $currentDirectory
     }
 
     It "Should do exactly the same thing as its alias" {
-	(pwd).Path | Should -Be (Get-Location).Path
+	(pwd).Path | Should -BeExactly (Get-Location).Path
     }
 }
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSDrive.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSDrive.Tests.ps1
@@ -19,23 +19,24 @@ Describe "Get-PSDrive" -Tags "CI" {
 
     It "Should be the same output between Get-PSDrive and gdr" {
 	$alias  = gdr
-	$actual = Get-PSDrive
+	$actual = "Get-PSDrive"
 
-	$alias | Should -Be $actual
+
+	$alias | Should -BeExactly $actual
     }
 
     It "Should return drive info"{
-        (Get-PSDrive Env).Name        | Should -Be Env
-        (Get-PSDrive Alias).Name      | Should -Be Alias
+        (Get-PSDrive Env).Name        | Should -BeExactly Env
+        (Get-PSDrive Alias).Name      | Should -BeExactly Alias
 
         if ($IsWindows)
         {
             (Get-PSDrive Cert).Root       | Should -Be \
-            (Get-PSDrive C).Provider.Name | Should -Be FileSystem
+            (Get-PSDrive C).Provider.Name | Should -BeExactly FileSystem
         }
         else
         {
-            (Get-PSDrive /).Provider.Name | Should -Be FileSystem
+            (Get-PSDrive /).Provider.Name | Should -BeExactly FileSystem
         }
     }
 
@@ -44,15 +45,15 @@ Describe "Get-PSDrive" -Tags "CI" {
     }
 
     It "Should return true that a drive that does not exist"{
-	!(Get-PSDrive fake -ErrorAction SilentlyContinue) | Should -Be $True
+	!(Get-PSDrive fake -ErrorAction SilentlyContinue) | Should -BeTrue
 	Get-PSDrive fake -ErrorAction SilentlyContinue    | Should -BeNullOrEmpty
     }
     It "Should be able to determine the amount of free space of a drive" {
         $dInfo = Get-PSDrive TESTDRIVE
-        $dInfo.Free -ge 0 | Should -Be $true
+        $dInfo.Free -ge 0 | Should -BeTrue
     }
     It "Should be able to determine the amount of Used space of a drive" {
         $dInfo = Get-PSDrive TESTDRIVE
-        $dInfo.Used -ge 0 | Should -Be $true
+        $dInfo.Used -ge 0 | Should -BeTrue
     }
 }
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSProvider.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSProvider.Tests.ps1
@@ -10,9 +10,9 @@ Describe "Get-PSProvider" -Tags "CI" {
 
 	$actual = Get-PSProvider FileSystem
 
-	$actual.Name | Should -Be "FileSystem"
+	$actual.Name | Should -BeExactly "FileSystem"
 
-	$actual.Capabilities | Should -Be "Filter, ShouldProcess, Credentials"
+	$actual.Capabilities | Should -BeExactly "Filter, ShouldProcess, Credentials"
     }
 
     It "Should be able to call a provider with a wildcard expression" {

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Service.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Service.Tests.ps1
@@ -58,7 +58,7 @@ Describe "Get-Service cmdlet tests" -Tags "CI" {
 
     $getservicecmd = [Microsoft.PowerShell.Commands.GetServiceCommand]::new()
     $getservicecmd.$parameter = $value
-    $getservicecmd.$parameter | Should -Be $value
+    $getservicecmd.$parameter | Should -BeExactly $value
   }
 
   It "Get-Service filtering works for '<script>'" -TestCases @(

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Hierarchical-Path.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Hierarchical-Path.Tests.ps1
@@ -8,41 +8,41 @@ Describe "Hierarchical paths" -Tags "CI" {
 
     It "should work with Join-Path " {
         $testPath = Join-Path $TestDrive testFile.txt
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work with platform's slashes" {
         $testPath = "$TestDrive$([IO.Path]::DirectorySeparatorChar)testFile.txt"
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work with forward slashes" {
         $testPath = "$TestDrive/testFile.txt"
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work with backward slashes" {
         $testPath = "$TestDrive\testFile.txt"
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work with backward slashes for each separator" {
         $testPath = "$TestDrive\testFile.txt".Replace("/","\")
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work with forward slashes for each separator" {
         $testPath = "$TestDrive/testFile.txt".Replace("\","/")
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work even if there are too many forward slashes" {
         $testPath = "$TestDrive//////testFile.txt"
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 
     It "should work even if there are too many backward slashes" {
         $testPath = "$TestDrive\\\\\\\testFile.txt"
-        Get-Content $testPath | Should -Be $data
+        Get-Content $testPath | Should -BeExactly $data
     }
 }
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
@@ -115,7 +115,7 @@ Describe "New-Item" -Tags "CI" {
 
         $fileInfo = Get-ChildItem $FullyQualifiedLink
         $fileInfo.Target | Should -BeNullOrEmpty
-        $fileInfo.LinkType | Should -Be "HardLink"
+        $fileInfo.LinkType | Should -BeExactly "HardLink"
     }
 }
 
@@ -147,8 +147,8 @@ Describe "New-Item with links" -Tags @('CI', 'RequireAdminOnWindows') {
 
         $fileInfo = Get-ChildItem $FullyQualifiedLink
         $fileInfo.Target | Should -Match ([regex]::Escape($FullyQualifiedFile))
-        $fileInfo.LinkType | Should -Be "SymbolicLink"
-        $fileInfo.Attributes -band $DirLinkMask | Should -Be $SymLinkMask
+        $fileInfo.LinkType | Should -BeExactly "SymbolicLink"
+        $fileInfo.Attributes -band $DirLinkMask | Should -BeExactly $SymLinkMask
     }
 
     It "Should create a symbolic link to a non-existing file without error" {
@@ -159,8 +159,8 @@ Describe "New-Item with links" -Tags @('CI', 'RequireAdminOnWindows') {
         $fileInfo = Get-ChildItem $FullyQualifiedLink
         $fileInfo.Target | Should -Be $target
         Test-Path $fileInfo.Target | Should -BeFalse
-        $fileInfo.LinkType | Should -Be "SymbolicLink"
-        $fileInfo.Attributes -band $DirLinkMask | Should -Be $SymLinkMask
+        $fileInfo.LinkType | Should -BeExactly "SymbolicLink"
+        $fileInfo.Attributes -band $DirLinkMask | Should -BeExactly $SymLinkMask
     }
 
     It "Should create a symbolic link to directory without error" {
@@ -172,7 +172,7 @@ Describe "New-Item with links" -Tags @('CI', 'RequireAdminOnWindows') {
 
         $fileInfo = Get-Item $FullyQualifiedLink
         $fileInfo.Target | Should -Match ([regex]::Escape($FullyQualifiedFolder))
-        $fileInfo.LinkType | Should -Be "SymbolicLink"
+        $fileInfo.LinkType | Should -BeExactly "SymbolicLink"
         $fileInfo.Attributes -band $DirLinkMask | Should -Be $DirLinkMask
 
         # Remove the link explicitly to avoid broken symlink issue