8000 Add negative tests for Copy-Item over remote sessions by kalgiz · Pull Request #6231 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add negative tests for Copy-Item over remote sessions #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 9, 2018
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,28 @@ Describe "Validate Copy-Item Remotely" -Tags "CI" {
Copy-Item -Path $filePath -FromSession $s -Destination $destinationFolderPath
ValidateCopyItemOperationForAlternateDataStream -filePath $filePath -streamName $streamName -expectedStreamContent $streamContent
}

It "Copy file to the same directory fails." {
$filePath = CreateTestFile
{ Copy-Item -Path $filePath -Destination $sourceDirectory -FromSession $s -ErrorAction Stop } | ShouldBeErrorId "System.IO.IOException,WriteException"
}

It "Copy directory with a -Destination parameter given as a file path fails." {
$filePath = CreateTestFile
$folderToCopy = GetDestinationFolderPath
{ Copy-Item -Path $folderToCopy -Destination $filePath -FromSession $s -ErrorAction Stop } | ShouldBeErrorId "CopyError,Microsoft.PowerShell.Commands.CopyItemCommand"
}

It "Copy-Item parameters -FromSession and -ToSession are mutually exclusive." {
$s1 = New-PSSession -ComputerName . -ea SilentlyContinue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ErrorAction instead of -ea

if (-not $s1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a Pester check.

$s1 | Should Not BeNullOrEmpty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the test in a try - finally block and Remove-PSSession $s1 in finally

{
throw "Failed to create PSSession for remote copy operations."
}
$filePath = CreateTestFile
$destinationFolderPath = GetDestinationFolderPath
{ Copy-Item -Path $filePath -Destination $destinationFolderPath -FromSession $s -ToSession $s1 -ErrorAction Stop } | ShouldBeErrorId "InvalidInput,Microsoft.PowerShell.Commands.CopyItemCommand"
}
}

Context "Validate Copy-Item Remotely using wildcards" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1401,3 +1401,4 @@ Describe "UNC paths" -Tags 'CI' {
}
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the extra line here?

0