8000 Add Password parameter to Get-PfxCertificate cmdlet by maybe-hello-world · Pull Request #6113 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add Password parameter to Get-PfxCertificate cmdlet #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 23, 2018
Merged

Add Password parameter to Get-PfxCertificate cmdlet #6113

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
15bf04e
Add Password parameter to Get-PfxCertificate cmdlet
maybe-hello-world Feb 6, 2018
b02f60c
Auto-Implemented Property used instead of manual implemention
maybe-hello-world Feb 6, 2018
b3955f5
Small comments changes
maybe-hello-world Feb 7, 2018
6312afd
Change behaviour to non-breaking and write tests
maybe-hello-world Feb 8, 2018
8592a2e
Fix test
maybe-hello-world Feb 8, 2018
64bd54a
Make test crossplatfrom
maybe-hello-world Feb 9, 2018
415b92e
Tabs to spaces cleanup
maybe-hello-world Feb 9, 2018
f46750f
Rename Force switch
maybe-hello-world Feb 9, 2018
17c1c41
Change generated certificate to existing
maybe-hello-world Feb 14, 2018
fd5d9f0
Rename switch according to committee decision
maybe-hello-world Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small comments changes
  • Loading branch information
@maybe-hello-world
maybe-hello-world committed Feb 7, 2018
commit b3955f5fc4a4074fc5f158b46ce919f6cc96756b
3 changes: 1 addition & 2 deletions src/Microsoft.PowerShell.Security/security/CertificateCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public string[] LiteralPath
private bool _isLiteralPath = false;

/// <summary>
/// Gets or sets the password for unlocking the certificate
/// Gets or sets the password for unlocking the certificate.
/// </summary>
[Parameter(Mandatory = false)]
public SecureString Password { get; set; }
Expand Down Expand Up @@ -190,7 +190,6 @@ protected override void ProcessRecord()

private static X509Certificate2 GetCertFromPfxFile(string path, SecureString password)
{
// Passing null password and DefaultKeySet here is equivalent to calling "new X509Certificate2(path)"
var cert = new X509Certificate2(path, password, X509KeyStorageFlags.DefaultKeySet);
return cert;
}
Expand Down
0