8000 Make PowerShell able to enable logging of script block execution on Unix platforms by daxian-dbw · Pull Request #5791 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Make PowerShell able to enable logging of script block execution on Unix platforms #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 8, 2018
Merged

Make PowerShell able to enable logging of script block execution on Unix platforms #5791

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
39af334
Enable logging on Linux through MshLog
daxian-dbw Dec 19, 2017
3dd86f5
Refactor 'PropertyAccessor.cs'
daxian-dbw Dec 21, 2017
263ec24
Rename 'PropertyScope' to 'ConfigScope'
daxian-dbw Dec 21, 2017
6ab1ad7
Rename file PropertyAccessor.cs to PSConfiguration.cs
daxian-dbw Dec 21, 2017
41c66db
Refactor GroupPolicy setting related code to use the configuration file
daxian-dbw Jan 3, 2018
117e83a
Add xUnit tests for reading Policy settings from config file
daxian-dbw Jan 3, 2018
a6c62bf
[Feature] Minor changes to make ScriptBlock logging work with SysLog
daxian-dbw Jan 4, 2018
167bbad
Address one of Dan's comments
daxian-dbw Jan 5, 2018
b4b864f
Re-enable group policy settings from registry
daxian-dbw Jan 5, 2018
3b5badc
Rename 'PowerShellProperties.json' to 'powershell.config.json'
daxian-dbw Jan 6, 2018
3b94173
[Feature] Change two methods to use 'private' modifier.
daxian-dbw Jan 6, 2018
6ee608f
[Feature] Consider a policy is undefined if none of its properties ar…
daxian-dbw Jan 7, 2018
01ecf4b
[Feature] Address Steve's new comments
daxian-dbw Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address one of Dan's comments
  • Loading branch information
@daxian-dbw
daxian-dbw committed Jan 5, 2018
commit 167bbad1d116ac41c2396eddeea7ddfcb07d1da9
5 changes: 2 additions & 3 deletions src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4756,10 +4756,9 @@ internal static ModuleLoggingGroupPolicyStatus GetModuleLoggingInformation(out I
{
if (moduleLogging.EnableModuleLogging == false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need multiple return paths? Why not if (... == false) else if (... == true) and set status in both cases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the original code, will update it to set status in both cases.

{
return ModuleLoggingGroupPolicyStatus.Disabled;
status = ModuleLoggingGroupPolicyStatus.Disabled;
}

if (moduleLogging.EnableModuleLogging == true)
else if (moduleLogging.EnableModuleLogging == true)
{
status = ModuleLoggingGroupPolicyStatus.Enabled;
moduleNames = moduleLogging.ModuleNames;
Expand Down
0