Add linux-arm tarball package to release build #5652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"linux-arm can only be built on Ubuntu" - why? |
Member
Author
|
@anmenaga It's from build.psm1: https://github.com/PowerShell/PowerShell/blob/master/build.psm1#L288 |
TravisEz13
reviewed
Dec 8, 2017
| if ($ExtraPackage -contains "tar-arm") { | ||
| ## Build 'linux-arm' and create 'tar.gz' package for it. | ||
| ## Note that 'linux-arm' can only be built on Ubuntu environment. | ||
| Start-PSBuild -Runtime linux-arm -PSModuleRestore |
Member
There was a problem hiding this comment.
Don't we need to build with at least the release tag?
Member
Author
|
@TravisEz13 Your comment has been addressed. Can you please take another look? Thanks! |
TravisEz13
approved these changes
Dec 8, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 9, 2017
Create linux-arm tarball package in our release build. Also moved the Linux-x64 tarball creation to Ubutntu 14.04, because Start-PSBuild adds additional symbolic link files when running on Red Hat Family distros. Note that linux-arm can only be built on Ubuntu, so the tar-arm package will also be generated from the Ubuntu 14.04.
TravisEz13
pushed a commit
that referenced
this pull request
Dec 10, 2017
Create linux-arm tarball package in our release build. Also moved the Linux-x64 tarball creation to Ubutntu 14.04, because Start-PSBuild adds additional symbolic link files when running on Red Hat Family distros. Note that linux-arm can only be built on Ubuntu, so the tar-arm package will also be generated from the Ubuntu 14.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #5571 -- Produce
linux-armtar.gz package in the release build.Create
linux-armtarball package in our release build.Also moved the
Linux-x64tarball creation to Ubutntu 14.04, becauseStart-PSBuildadds additional symbolic link files when running on Red Hat Family distros.Note that
linux-armcan only be built on Ubuntu, so thetar-armpackage will also be generated from the Ubuntu 14.04.PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature tests